Skip to content

Commit

Permalink
rename SubscriptionManager to Subscription
Browse files Browse the repository at this point in the history
  • Loading branch information
weboko committed Oct 27, 2024
1 parent 09127df commit 2a5df25
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
13 changes: 6 additions & 7 deletions packages/sdk/src/protocols/filter/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import {
import { PeerManager } from "../peer_manager.js";

import { MessageCache } from "./message_cache.js";
import { SubscriptionManager } from "./subscription_manager.js";
import { Subscription } from "./subscription.js";
import { buildConfig } from "./utils.js";

const log = new Logger("sdk:filter");
Expand All @@ -36,7 +36,7 @@ class Filter implements IFilter {

private readonly config: FilterProtocolOptions;
private readonly messageCache: MessageCache;
private activeSubscriptions = new Map<string, SubscriptionManager>();
private activeSubscriptions = new Map<string, Subscription>();

public constructor(
private connectionManager: ConnectionManager,
Expand Down Expand Up @@ -186,7 +186,7 @@ class Filter implements IFilter {
this.getActiveSubscription(pubsubTopic) ??
this.setActiveSubscription(
pubsubTopic,
new SubscriptionManager(
new Subscription(
pubsubTopic,
this.protocol,
this.connectionManager,
Expand Down Expand Up @@ -263,17 +263,16 @@ class Filter implements IFilter {
return toAsyncIterator(this, decoders);
}

//TODO: move to SubscriptionManager
private getActiveSubscription(
pubsubTopic: PubsubTopic
): SubscriptionManager | undefined {
): Subscription | undefined {
return this.activeSubscriptions.get(pubsubTopic);
}

private setActiveSubscription(
pubsubTopic: PubsubTopic,
subscription: SubscriptionManager
): SubscriptionManager {
subscription: Subscription
): Subscription {
this.activeSubscriptions.set(pubsubTopic, subscription);
return subscription;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import { DEFAULT_LIGHT_PUSH_FILTER_CHECK_INTERVAL } from "./constants.js";

const log = new Logger("sdk:filter:subscription_manager");

export class SubscriptionManager implements ISubscription {
export class Subscription implements ISubscription {
private reliabilityMonitor: ReceiverReliabilityMonitor;

private keepAliveTimeout: number;
Expand Down

0 comments on commit 2a5df25

Please sign in to comment.