refactor(sponsorkit): address CodeRabbit feedback on #5724#5731
Draft
taliesin-ai wants to merge 1 commit into
Draft
refactor(sponsorkit): address CodeRabbit feedback on #5724#5731taliesin-ai wants to merge 1 commit into
taliesin-ai wants to merge 1 commit into
Conversation
- fold the PR-metric thresholds into Band.PRMinCredit so the band list and thresholds cannot drift apart and panic - gate the animated ring's hover-only bloom/fast layers on Band.Hover, matching the static branch - throttle the per-login lookupUser fallbacks like the paginated fetches, so changelog-only and PR-only lookups cannot burst into GitHub's secondary rate limits - table-driven unit tests for changelogMentions and Credit()
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5724, which was merged while CodeRabbit's review was still processing. Addresses the four actionable findings from its review:
PRMinCreditfield onBanditself, so the band list and thresholds cannot drift apart and panic.Band.Hoveris set, matching the static branch (no output change for the current config).lookupUserfallbacks (changelog-only and PR-only contributors) are throttled at the same 100ms cadence as the paginated fetches, so they can't burst into GitHub's secondary rate limits during the nightly run.changelogMentions(profile-link precedence, npm scopes, display handles, emails, trailing hyphens) andCredit()(both metrics, mention max-taking, commit-only floor).Two findings were declined with reasons — see the reply on #5724: the avatar raw-bytes fallback (alpha composites over the card background inside the SVG, and gating on
Opaque()would forfeit the identicon size win the fallback exists for) and the shared embed component (the markup spans two different doc systems, Astro Starlight and Docusaurus, plus the LLM translation pipeline).