Skip to content

refactor(sponsorkit): address CodeRabbit feedback on #5724#5731

Draft
taliesin-ai wants to merge 1 commit into
masterfrom
chore/sponsorkit-coderabbit-feedback
Draft

refactor(sponsorkit): address CodeRabbit feedback on #5724#5731
taliesin-ai wants to merge 1 commit into
masterfrom
chore/sponsorkit-coderabbit-feedback

Conversation

@taliesin-ai

Copy link
Copy Markdown
Collaborator

Follow-up to #5724, which was merged while CodeRabbit's review was still processing. Addresses the four actionable findings from its review:

  • Band/prBandMins coupling: the PR-metric thresholds are now a PRMinCredit field on Band itself, so the band list and thresholds cannot drift apart and panic.
  • Hover gating: the animated ring's hover-only bloom/fast layers are now emitted only when Band.Hover is set, matching the static branch (no output change for the current config).
  • Rate limiting: the per-login lookupUser fallbacks (changelog-only and PR-only contributors) are throttled at the same 100ms cadence as the paginated fetches, so they can't burst into GitHub's secondary rate limits during the nightly run.
  • Test coverage: table-driven unit tests for changelogMentions (profile-link precedence, npm scopes, display handles, emails, trailing hyphens) and Credit() (both metrics, mention max-taking, commit-only floor).

Two findings were declined with reasons — see the reply on #5724: the avatar raw-bytes fallback (alpha composites over the card background inside the SVG, and gating on Opaque() would forfeit the identicon size win the fallback exists for) and the shared embed component (the markup spans two different doc systems, Astro Starlight and Docusaurus, plus the LLM translation pipeline).

- fold the PR-metric thresholds into Band.PRMinCredit so the band list
  and thresholds cannot drift apart and panic
- gate the animated ring's hover-only bloom/fast layers on Band.Hover,
  matching the static branch
- throttle the per-login lookupUser fallbacks like the paginated
  fetches, so changelog-only and PR-only lookups cannot burst into
  GitHub's secondary rate limits
- table-driven unit tests for changelogMentions and Credit()
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7bb1626f-67bc-43b3-8198-d4ced6aac0d9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/sponsorkit-coderabbit-feedback

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants