"respond" review mode, review mode settings vars and README. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think of this, @gasman? |
|
Hi again! Just for clarification, I have to say that when accessing the review via the sent link to someone to review, the expected behaviour is there (nice modal appears by default), so it is not that the plugin doesn't work. My PR just makes it a bit more customizable via settings variables and expands the nice behaviour by default to more cases, not only when accessing via the sent link. |
|
PR reopened from the correct branch in my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
As commented on issue #2 this would have a better behaviour out of the box.
By default:
commentmode enabledrespondmode enabledviewmode enabledSettings variables to modify default behaviour have been enabled:
WAGTAIL_REVIEW_DEFAULT_SUBMITTER_MODEWAGTAIL_REVIEW_DEFAULT_REVIEWER_MODEWAGTAIL_REVIEW_DEFAULT_USER_MODEThe README has been edited to explain this better.
I felt this was one of the issues I had when I first looked at the code and I thought the README changes could help better understand the functionality.