Added visit page view #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaedroho
force-pushed
the
feature/74-visit-api
branch
from
56cdd0d
to
9f4a015
Compare
| @@ -137,7 +137,7 @@ def add_page_visit(self, page): | |||
| visit_count.append({ | |||
| 'slug': page.slug, | |||
| 'id': page.pk, | |||
| 'path': self.request.path, | |||
| 'path': path or self.request.path, | |||
There was a problem hiding this comment.
I'm now actually wondering if using self.request.path for fallback here is the correct idea. Perhaps we should always use the full path based on the passed page ?
kaedroho
force-pushed
the
feature/74-visit-api
branch
2 times, most recently
from
096e18d
to
03f18d4
Compare
Fixes #74 Allows frontend users to submit page views and retrieve segments while behind a cache or CDN.
kaedroho
force-pushed
the
feature/74-visit-api
branch
from
03f18d4
to
2ae115c
Compare
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
=========================================
Coverage ? 62.04%
=========================================
Files ? 38
Lines ? 3183
Branches ? 0
=========================================
Hits ? 1975
Misses ? 1208
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
Allows frontend users to submit page views and retrieve segment info while behind a cache or CDN.