Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wagtail 6.0 support #32

Merged
merged 3 commits into from
Jan 30, 2024
Merged

Wagtail 6.0 support #32

merged 3 commits into from
Jan 30, 2024

Conversation

gasman
Copy link
Contributor

@gasman gasman commented Jan 27, 2024

Towards #31

Copy link
Member

@lb- lb- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gasman gasman force-pushed the admin/wagtail-6 branch 2 times, most recently from a31e928 to 117e7b1 Compare January 27, 2024 02:48
@gasman
Copy link
Contributor Author

gasman commented Jan 27, 2024

Worth noting that this is also the root cause of the current test failures on wagtail-localize - all wagtail-localize tests pass when run against a patched modeladmin.

@lb-
Copy link
Member

lb- commented Jan 27, 2024

Just took another look. Changes make sense. Not sure if you wanted to wait for a review from Sage though.

@laymonage laymonage self-requested a review January 30, 2024 09:26
Copy link
Collaborator

@laymonage laymonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think we should drop support for Django <4.2 and Wagtail <5.2, I'll do that separately.

Copy link
Collaborator

@laymonage laymonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to note that while this fixes the crash, the UI is broken due to other changes to the listing styles in 6.0:

image

I'll fix this separately.

@laymonage laymonage merged commit c63ed0a into wagtail-nest:main Jan 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants