Fixed the toolbar in Wagtail 4. #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y on Wagtail 4. The fixes include: * Increased the height of the top-padding which gets added when the toolbar appears. This makes room for it always being two rows in Wagtail 4, due to the limited width of rich text editors. * Removed the .object prefix on the CSS we apply, since Wagtail 4 page editors don't use that class any more. * Added 44px to the 'top' position set by the JS for the toolbar, to account for the changes in Wagtail 4's editor UI. * Made the scroll and resize events trigger for both the `window` object and '.content-wrapper', since the window doesn't scroll any more in Wagtail 4. The window events are retained because I think they're still relevant in Wagtail 3.
Reluctantly.
|
Hi, have you also fixed the "resize to make room for the toolbar" issue? |
Yes. The toolbar is now completely functional in Wagtail 4. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fixes include:
windowobject and '.content-wrapper', sincewindowdoesn't scroll any more in Wagtail 4. Thewindowevents are retained because I think they're still relevant in Wagtail 3.