Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated responses to match Wagtail 4 chooser names #35

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cnk
Copy link
Collaborator

@cnk cnk commented Nov 4, 2022

Fixes #33

However, changing these 2 lines means at this point, the code is no longer agnostic between Wagtail 3 and 4. @lb- I don't know a trick like the try/catch for python imports that would allow this to work on both sets. Should we create a pypi release with the previous code (and stating Wagtail <= 3) and then merge this and declare this Wagtail 4+? If so, should we go ahead and remove the ifs in the imports?

(I have tested this fix and it works on Wagtail 4.0 and 4.1)

@lb-
Copy link
Member

lb- commented Nov 6, 2022

Hey @cnk - it probably makes sense to try to do a 3.0 compatible release and then do this change as a different one that is 4.0 compatible but drops < 3.0.

@lb-
Copy link
Member

lb- commented Feb 1, 2023

https://github.com/wagtail-nest/wagtail-hallo/blob/main/wagtail_hallo/test/tests/hallo.test.js

Wagtail uses Jest - but here are the docs https://jestjs.io/

npm ci
npm run test # run all tests
npm run test -- --watch

https://jestjs.io/docs/cli - to pass in cli arguments to npm scripts remember to use the -- before these

@nickmoreton
Copy link

@cnk FYI I just submitted #38 for the wagtail 4.2 upgrade. It might mean that this change isn't required. 🤞

@zerolab
Copy link
Collaborator

zerolab commented Feb 7, 2023

This change is very much required in that it related to the JS callbacks for the choosers

coredumperror added a commit to coredumperror/wagtail-hallo that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image and document choosers don't update content
4 participants