Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wagtail 5.1 and 5.2 + Python 3.12 support #93

Merged

Conversation

Stormheg
Copy link
Member

@Stormheg Stormheg commented Nov 4, 2023

No description provided.

On Wagtail 5.1 and later, this raises ImproperlyConfigured: You're using the staticfiles app without having set the required STATIC_URL setting
No longer supported since this August.
Copy link
Collaborator

@loicteixeira loicteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, thank you 🙏
Do you think it requires a new PyPI version if there are no code changes?

Comment on lines -34 to -35
[wheel]
universal=1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Comment on lines +6 to +8
py{38,39,310,311}-django{32,40,41}-wagtail41 # Wagtail 4.1 LTS - all supported Python - all Django
py{38,39,310,311,312}-django{32,41,42}-wagtail{50,51,52} # Wagtail 5.0, 5.1 and 5.2 LTS - all supported Python - all Django
wagtailmain # Wagtail main latest compatible version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per our README, we aim to officially support LTS + current, so today it would mean 5.2 only. I guess we decided on this at some point to lessen the maintenance need, but there's also no reason not to support previous versions if there is no code change or compatibility layer to make it work. So I think we can merge like this.

@loicteixeira loicteixeira merged commit bb04de0 into wagtail-nest:main Nov 5, 2023
8 checks passed
@Stormheg
Copy link
Member Author

Stormheg commented Nov 5, 2023

@loicteixeira I don't think a release is strictly necessary but wouldn't be opposed if we did one.

@Stormheg Stormheg deleted the chore/update-supported-versions branch November 5, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants