푸시 알림 딥링크 #170
Merged
푸시 알림 딥링크 #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuTaK97
commented
May 28, 2023
|
|
||
| companion object { | ||
| const val URL_SCHEME = "url_scheme" | ||
| val SCHEME = if (BuildConfig.DEBUG) "snutt-dev://" else "snutt://" |
There was a problem hiding this comment.
고민 1: 이 값은 strings.xml에 secret으로 넣는 게 맞을지?
There was a problem hiding this comment.
잘 몰라서 검색해봤는데 스킴을 숨기는 이유가 외부에서 악의적으로 같은 스킴을 쓰는걸 막기 위해서야?
https://medium.com/prnd/%EB%94%A5%EB%A7%81%ED%81%AC%EC%9D%98-%EB%AA%A8%EB%93%A0%EA%B2%83-feat-app-link-universal-link-deferred-deeplink-61d6cf63a0a5
There was a problem hiding this comment.
그런 이유도 있긴 한데 우리 앱 정도에서 신경쓸 건 아니긴 해
그것보다는 그냥 우리 app_name이나 base_url 같은 거랑 같은 종류의 string이 아닌가 해서 고민해봤음
There was a problem hiding this comment.
음...저는동의해요 비슷한 종류의 string인거 같기도 하고 조심해서 나쁠거 없고?ㅋㅋㅋ 좋은듯
|
|
||
| private fun handleDeepLink() { | ||
| intent.extras?.getString(URL_SCHEME)?.let { | ||
| intent.data = Uri.parse(it) |
There was a problem hiding this comment.
앞으로 딥링크 외에도 푸시알림에 들어있는 정보는 모두 여기서 처리하기
| @@ -233,10 +238,12 @@ class RootActivity : AppCompatActivity() { | |||
|
|
|||
| private fun NavGraphBuilder.composable2( | |||
| route: String, | |||
| deepLinks: List<NavDeepLink> = listOf(navDeepLink { uriPattern = "$SCHEME$route" }), | |||
There was a problem hiding this comment.
TODO: route가 고도화될 경우 대응 필요
eastshine2741
approved these changes
May 31, 2023
added 2 commits
June 15, 2023 11:28
JuTaK97
force-pushed
the
jutak/notification-deep-link
branch
from
d1f6378
to
1089e15
Compare
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.