게시글, 댓글에 프로필사진 보여주기 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjshim2003
reviewed
Aug 23, 2024
| CommunityProfilePicture(model = null) // TODO: 서버에서 프로필이미지 내려주면 반영하기 | ||
| CommunityProfilePicture(model = post.profilePicture) |
There was a problem hiding this comment.
지금은 프로필이 비어 있으면 서버에서 기본 프로필을 내려 주지 않아서 클라에 따로 리소스 수정하고 구현해야 한다는 말이지?
There was a problem hiding this comment.
서버에 문의해보니까 기본 프로필이미지를 내려주는 대신 기본인지 아닌지 Bool을 내려줄려는 거 같아서 기본일때 user의 프로필 이미지를 R.drawable에서 가져다 쓰는 방법으로 해야할 듯? UserAccount(닉네임이랑 프로필이미지 바꾸는 화면)에서도 그렇게 할려고
kevin990222
approved these changes
Aug 24, 2024
| CommunityProfilePicture(model = null) // TODO: 서버에서 프로필이미지 내려주면 반영하기 | ||
| CommunityProfilePicture(model = post.profilePicture) |
There was a problem hiding this comment.
서버에 문의해보니까 기본 프로필이미지를 내려주는 대신 기본인지 아닌지 Bool을 내려줄려는 거 같아서 기본일때 user의 프로필 이미지를 R.drawable에서 가져다 쓰는 방법으로 해야할 듯? UserAccount(닉네임이랑 프로필이미지 바꾸는 화면)에서도 그렇게 할려고
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
추가된 점
기타