Feat/account #21
Merged
Feat/account #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scripter36
approved these changes
Apr 28, 2024
| onClick={() => onSubmit?.(sessionName)} | ||
| onClick={() => { | ||
| onSubmit?.(sessionName); | ||
| setSessionState("pending"); |
There was a problem hiding this comment.
onSubmit이 실패할 수도 있어서 바로 pending으로 하면 의도하지 않은 state가 될 수도 있을 듯
| queryClient.invalidateQueries({ | ||
| queryKey: ["classId"], | ||
| }); | ||
| refetch(); |
There was a problem hiding this comment.
refetch보다는 위의 invalidateQueries에서 queryKey를 ["currentSessionInfo", courseId] 로 넣어주면 될 듯?
There was a problem hiding this comment.
이거 InfoCard.tsx에서도 rerender 해줘야하는데 InfoCard.tsx랑 CodePopup.tsx에서 쓴거처럼 BroadcastChannel 쓰면 되려나?
There was a problem hiding this comment.
["currentSessionInfo", courseId] 로 invalidate 하면 useCurrentSessionInfo 값이 바뀌니 InfoCards 쪽에서도 자동으로 업데이트되지 않나
|
2번은 dev 가서 해 보니 차라리 버튼이 없으면 선택지가 하나밖에 없어지니 더 괜찮을 것 같기도? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경점
2에서 activate하면 delete session은 못하고 deactivate만 할 수 있는데 이때 delete session 버튼을 disable 해놓기 vs 그냥 숨겨버리기 뭐로 하는게 좋으려나