fix: use memory recommendation format when there is no request

wI2L · Oct 13, 2022 · 3d829d2 · 3d829d2
1 parent 0af9fdf
commit 3d829d2
Showing 1 changed file with 20 additions and 12 deletions.
diff --git a/cli/table.go b/cli/table.go
@@ -94,22 +94,30 @@ func (tr tableRow) toTableData(flags *Flags, isChild bool) []string {
 		)
 	}
 	rowData = append(rowData, formatPercentage(tr.CPUDifference, flags))
+
 	if flags.wide {
-		var str string
-		d := inf.Dec{}
-		d.Round(tr.Recommendations.Memory.AsDec(), 0, inf.RoundUp)
-		b := d.UnscaledBig()
-		switch tr.Requests.Memory.Format {
-		case resource.DecimalSI:
-			str = humanize.BigBytes(b, 2)
-		case resource.BinarySI:
-			str = humanize.BigIBytes(b, 2)
-		default:
-			str = tr.Recommendations.Memory.String()
+		recoStr := tableUnsetCell
+		if tr.Recommendations.Memory != nil {
+			d := inf.Dec{}
+			d.Round(tr.Recommendations.Memory.AsDec(), 0, inf.RoundUp)
+			b := d.UnscaledBig()
+
+			if tr.Requests.Memory != nil {
+				switch tr.Requests.Memory.Format {
+				case resource.DecimalSI:
+					recoStr = humanize.BigBytes(b, 2)
+				case resource.BinarySI:
+					recoStr = humanize.BigIBytes(b, 2)
+				default:
+					recoStr = tr.Recommendations.Memory.String()
+				}
+			} else {
+				recoStr = tr.Recommendations.Memory.String()
+			}
 		}
 		rowData = append(rowData,
 			formatQuantity(tr.Requests.Memory),
-			str,
+			recoStr,
 		)
 	}
 	rowData = append(rowData, formatPercentage(tr.MemoryDifference, flags))