Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TuxedoDapp #2112

Merged
merged 28 commits into from
Jan 18, 2024
Merged

TuxedoDapp #2112

merged 28 commits into from
Jan 18, 2024

Conversation

AltiMario
Copy link
Contributor

@AltiMario AltiMario commented Nov 17, 2023

Project Abstract

Develop a Tuxedo Web Wallet and Dapp.

Our goal is to showcase the potential of Polkadot using the UTXO paradigm for the end user, leveraging Tuxedo. The project will consist of two key stages:

  • Stage 1: Developing a simple Web Wallet
  • Stage 2: Developing a basic Dapp

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or Polkadot (USDC & USDT) address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

AltiMario and others added 4 commits November 17, 2023 15:30
1st iteration of the proposal
Removed the smart contract part and piece_contract development , since it is not the scope of Dapp development .

Smart contract development needs support from underlaying tuxedo runtime.
cleaning up
Copy link
Contributor

github-actions bot commented Nov 17, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@AltiMario
Copy link
Contributor Author

I have read and hereby sign the Contributor License Agreement.

1 similar comment
@NadigerAmit
Copy link
Contributor

I have read and hereby sign the Contributor License Agreement.

@takahser takahser self-requested a review November 20, 2023 10:06
@takahser takahser self-assigned this Nov 20, 2023
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AltiMario could you add the file extension .md?

Some further thoughts:

  • for UI-based deliverables (such as the wallet or the dApp) we'd require you to show us some wireframes, so we know what to expect
  • M2 is currently very vague. Please specify which features you're planning to implement there (e.g. "manage their NFT-based pet collections" => what does "manage" include exactly?)

For the sake of completeness I'm going to link the two mentioned issues here:

(cc @JoshOrndorff, would you be open to assist the MLabs team in case of questions during the implementation if we end up signing a grant?)

Finally, @AltiMario the price is quite a bit higher than initially anticipated. I was wondering if you'd be open to reduce the price.

applications/TuxedoDapp Outdated Show resolved Hide resolved
applications/TuxedoDapp Outdated Show resolved Hide resolved
applications/TuxedoDapp Outdated Show resolved Hide resolved
applications/TuxedoDapp Outdated Show resolved Hide resolved
applications/TuxedoDapp Outdated Show resolved Hide resolved
applications/TuxedoDapp Outdated Show resolved Hide resolved
@takahser takahser added the changes requested The team needs to clarify a few things first. label Nov 23, 2023
Updated the file extension to .md
Updated  below :
1. Meaning of Feature Parity
2. Updated browsers which will be supported .
3. Meaning and Scope of "Manage NFT" in M2(Dapp) section
Updated the semantic issues.
Updated the M2 features  i.e DApp features supported to Kitties based on the features by Kitties pieces in blockchain code .
updated M2 deliverables in all places in accordance with kitties pieces.
@JoshOrndorff
Copy link
Contributor

I'm excited to see this proposal! And I'm certainly willing to answer questions and provide guidance.

I want to call your attention to Off-Narrative-Labs/Tuxedo#30 as well. The current CLI wallet is developed by using the same types as the template runtime. If a chain developer comes along and adds or removes tuxedo pieces, small corresponding changes need to be made to the wallet. You may choose to design your wallet in this way as well, and I think such a wallet is very valuable.

A much more elegant and general solution would be to have a standard metadata format like FRAME has (although it can be much simpler than FRAME's especially at first). This would allow wallets to detect the existence of a particular Tuxedo piece and adapt accordingly like Polakdot JS Apps does.

Finally, regarding the price, I am not w3f or grants committee, so I'll just share these few thoughts because. Our original Tuxedo Grant was to develop Tuxedo Core, Template, and CLI wallet. If the scope is just to achieve feature parity with the CLI wallet plus fix #62, I'd say that is a smaller effort than our original grant. If the scope includes a metadata format and dynamic wallet, I expect it to be a similar or perhaps slightly larger effort than the original.

applications/TuxedoDapp.md Outdated Show resolved Hide resolved
applications/TuxedoDapp.md Outdated Show resolved Hide resolved
applications/TuxedoDapp.md Outdated Show resolved Hide resolved
applications/TuxedoDapp Outdated Show resolved Hide resolved
NadigerAmit and others added 9 commits November 28, 2023 16:06
Updated DApp functionalities to support the trading, updating features, searching of kitties ,etc .
Updated the IPFS requirement to store meta data of kitty.
Wireframes links are updated.
After a better analysis of the scope, we decided to cut the cost by 10% but maintain 3 months as the total estimated duration.
fixed some typos and comments.
keeganquigley
keeganquigley previously approved these changes Dec 5, 2023
@keeganquigley keeganquigley added the ready for review The project is ready to be reviewed by the committee members. label Dec 6, 2023
@AltiMario
Copy link
Contributor Author

KYC/KYB checks completed

semuelle
semuelle previously approved these changes Dec 12, 2023
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application and the updates, @AltiMario. Happy to approve.

takahser
takahser previously approved these changes Dec 12, 2023
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AltiMario thanks for the updates, LGTM now 👍

@github-actions github-actions bot added the stale label Dec 27, 2023
@takahser takahser removed the stale label Jan 8, 2024
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving this.
@keeganquigley @semuelle feel free to re-approve, @AltiMario accidentally overwrote and reverted the changes, hence there are no changes since the approval.

@JoshOrndorff
Copy link
Contributor

So there are already three approvals right? Is anything blocking this?

@Noc2
Copy link
Collaborator

Noc2 commented Jan 9, 2024

So there are already three approvals right? Is anything blocking this?

KYB still needs to be completed.

@JoshOrndorff
Copy link
Contributor

@AltiMario seems to think that is completed. See #2112 (comment)

@keeganquigley
Copy link
Contributor

Thanks @JoshOrndorff looks like the latest submission is still pending, we should have results on this tomorrow.

@AltiMario
Copy link
Contributor Author

I apologize for the inconvenience, but there seems to be an error with the document that the MLabs administration previously signed. I believe due to the recent holiday, they forgot to address this issue.
I have contacted them and urged them to resolve it as soon as possible.

@semuelle
Copy link
Member

@AltiMario, who should I reach out to and how to discuss the KYB?

@AltiMario
Copy link
Contributor Author

hi @semuelle the person in charge of the KYB is Deepak Kumar ([email protected])

@semuelle semuelle removed the admin-review This application requires a review from an admin. label Jan 18, 2024
@semuelle semuelle merged commit 4950942 into w3f:master Jan 18, 2024
7 of 9 checks passed
Copy link
Contributor

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at [email protected] and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

@AltiMario
Copy link
Contributor Author

Awesome, thanks for the opportunity and for supporting me in the process!

@semuelle
Copy link
Member

Sorry it took this long, @AltiMario. We finally managed to resolve the KYC/KYB issues last night.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants