Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amendment to Chainviz v1 application #1906

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

kukabi
Copy link
Contributor

@kukabi kukabi commented Aug 14, 2023

This an amendment to the original Chainviz v1 application with the following changes/updates:

  • Removed shader development. New design does not currently require custom shader development.
  • Removed extrinsic and event arguments from block contents. We do display the list of extrinsics and events, and it is technically very feasible to get arguments for both, but the design doesn't have space for arguments. We might include arguments in the future versions should we move in more of a block explorer direction.
  • Removed the development of the custom block details service for the SubVT backend. Polkadot JS API and Polkaholic XCM API are perfectly enough for all our needs to get block content and XCM data. Furthermore our assumption that it should be possible to get complete XCM data just using the relay chain storage turned out false. Polkaholic indexes all data from all chains to be able to present complete XCM data, end to end.
  • Merged two milestones into one and changed the duration to 8 months taking late 2022 as the start date, and workload at 0.2 FTE.

Thanks.

@CLAassistant
Copy link

CLAassistant commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

@kukabi kukabi mentioned this pull request Aug 14, 2023
10 tasks
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update. Are you also planning to deliver the milestone now? Regarding the milestone table, it would be nice to have additional details and the open-source software as part of the delivery. At the moment, it looks a little bit like you are only delivering the deployed Web application, which we usually don't care so much about.

@Noc2 Noc2 added changes requested The team needs to clarify a few things first. amendment This PR proposes changes to an existing application. labels Aug 14, 2023
@kukabi kukabi closed this Aug 14, 2023
@kukabi kukabi reopened this Aug 14, 2023
@kukabi
Copy link
Contributor Author

kukabi commented Aug 14, 2023

Thanks a lot for the update. Are you also planning to deliver the milestone now? Regarding the milestone table, it would be nice to have additional details and the open-source software as part of the delivery. At the moment, it looks a little bit like you are only delivering the deployed Web application, which we usually don't care so much about.

@Noc2 Sorry, yes we are going to deliver the complete source code of the software and documentation on how to run it. I have updated the milestone table. Development is happening at github.com/helikon-labs/chainviz-v1 at the moment, but will be moved over to the main Chainviz main repository once the development is completed.

And we're planning the delivery for the end of this week.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I'm already happy to go ahead with the amendment and share it with the rest of the team.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Aug 15, 2023
@kukabi
Copy link
Contributor Author

kukabi commented Aug 15, 2023

Thanks @Noc2, we're doing our best to complete & submit it all this week.

@takahser
Copy link
Collaborator

@kukabi mostly LGTM, but could you help me out with explaining me what shaders are?

@kukabi
Copy link
Contributor Author

kukabi commented Aug 16, 2023

Sure, @takahser. A shader is basically a small program that runs during the 3D render and tells the renderer how to render certain objects/surfaces. They are utilized for custom graphics programming where either the graphical primitives provided by the 3D framework are not enough, or don't perform well enough.

We were able to satisfy the complete visualization in a performant manner using the graphical primitives provided by Three.js, our framework of choice for WebGL graphics. So it turned out we do not need to program custom shaders for our 3D world.

As a note, the alpha version of the software doesn't use custom shaders either.

Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takahser takahser merged commit 5a30ab5 into w3f:master Aug 16, 2023
3 checks passed
taqtiqa-mark pushed a commit to taqtiqa-mark/Grants-Program that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants