-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amendment to Chainviz v1 application #1906
Conversation
e5cb6b7
to
351f5ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the update. Are you also planning to deliver the milestone now? Regarding the milestone table, it would be nice to have additional details and the open-source software as part of the delivery. At the moment, it looks a little bit like you are only delivering the deployed Web application, which we usually don't care so much about.
351f5ea
to
5ac8043
Compare
5ac8043
to
8055f9d
Compare
@Noc2 Sorry, yes we are going to deliver the complete source code of the software and documentation on how to run it. I have updated the milestone table. Development is happening at github.com/helikon-labs/chainviz-v1 at the moment, but will be moved over to the main Chainviz main repository once the development is completed. And we're planning the delivery for the end of this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. I'm already happy to go ahead with the amendment and share it with the rest of the team.
Thanks @Noc2, we're doing our best to complete & submit it all this week. |
@kukabi mostly LGTM, but could you help me out with explaining me what shaders are? |
Sure, @takahser. A shader is basically a small program that runs during the 3D render and tells the renderer how to render certain objects/surfaces. They are utilized for custom graphics programming where either the graphical primitives provided by the 3D framework are not enough, or don't perform well enough. We were able to satisfy the complete visualization in a performant manner using the graphical primitives provided by Three.js, our framework of choice for WebGL graphics. So it turned out we do not need to program custom shaders for our 3D world. As a note, the alpha version of the software doesn't use custom shaders either. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This an amendment to the original Chainviz v1 application with the following changes/updates:
Thanks.