-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pass3 application #1886
Add Pass3 application #1886
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the application. Looks like an interesting project. Could you add more technical details to the specification of the milestone tables? For example, how exactly do you combine passkey with the private key of the Polkadot account? What does asset management mean (e.g., listing pallets that you will support)?
pinging @andrwlt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, and sorry for the late reply. I will mark it as ready for review. But could you potentially reduce the price? The application seems rather expensive to me compared to your previous project: #776
Hi @Noc2, |
Hi @andrwlt thanks for the application. One question I have off the bat: is the Apple Passkey system open-source? If not, I wonder if it might conflict with our guidelines regarding relying on closed-sourced systems. |
Hi @keeganquigley |
Hi @andrwlt sorry for the late reply:
|
Hi @keeganquigley,
|
Thanks @andrwlt for the thorough answers. Yes, I think I'd personally be more apt to approve it if milestone 3 was omitted and moved to a follow-up grant. That way we can see the core implementation in action first, before all the additional features are implemented. Let me know if this works for you. |
Hi @keeganquigley, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, @andrwlt. Happy to support your proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates @andrwlt much appreciated. LGTM.
@semuelle @keeganquigley Thank for your supports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrwlt, apologies for the delay on my end.
A few points and questions for clarity:
- I've noticed that this proposal bears resemblance to the hashed-wallet mobile app which also received a grant and has been delivered. It might be beneficial to address this in the Ecosystem Fit section, highlighting the differences in your solution.
- Considering the similarities with the hashed wallet, perhaps it's worth looking into reusing their implementation? You could explore forking or even collaborating with the grantee, given that their repo hasn't had recent activity since March.
- Could you share the long-term vision for this project? Do you see the team maintaining it post-grant? If so, what drives that intention?
- In a previous comment, you referenced a "month-long user research". Is it possible to share some insights from that study? A private share would work if public disclosure isn't feasible.
- Regarding your team's proficiency: What experience do you hold in web UIs or, more pertinently, mobile apps? The lo-fi wireframes are a good start, but any validation of your capability would be appreciated.
hi @takahser, thank you for your inquiry. To address your questions:
Please let me know if I am missing anything else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrwlt honestly for a wallet application with passkey integration that would only work on mobile anyway I see more value in a native mobile application, due to several advantages such as native push notifications, biometric authentication access (fingerprint/face id), enhanced offline usage, app store visibility and general device integration, also potentially with other wallet applications.
I reached out to the maintainers of hashed wallet and they'd be very happy to collab with you guys. I think there is much more value in streamlining the development efforts and building on the existing code base to enhance this native app, rather than rewriting everything. Personally, I'd be very interested to support a joint-effort like that, but I'm not really keen on supporting the current proposal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @takahser proposal makes a lot of sense. Have you considered working together with another wallet provider in the ecosystem?
Thank you for sharing your perspective. We recognize and concur with your suggestion that collaborating with existing wallet providers will be more efficient than starting from scratch. However, at this time, our team is hesitant to partner with others due to potential challenges arising from our team culture and workflow. For instance, our team values face-to-face interactions for quick discussions, which would be hindered by collaborating with a remote team and could slow down the development process. We are contemplating a balanced approach, such as modifying the proposal to develop an SDK for wallets that implement WebAuthentication and FIDO standards. This SDK could then be used by various wallet providers. However, if we choose this path, it will necessitate further research to ensure its versatility across multiple use cases. |
Just to be clear, your team would most likely be the main contributor to that project for the scope of the passkey feature. So I don't think there should be any challenges of that nature. If you're interested I can make an Element group and discuss with the other team there to clear up any questions. |
hi @takahser, thank for clarifying. I've sent you a message on Matrix. |
This comment was marked as outdated.
This comment was marked as outdated.
Thank you @takahser. We greatly value the council's evaluation, feedback, and support 🙏 |
Pass3
Pass3 is a crypto wallet, engineered for simplicity without compromising security. It leverages Passkeys for effortless wallet setup and employs a social guard system for account recovery in case of device loss. Built as a mobile-first web application, Pass3 ensures seamless functionality across both mobile and desktop platforms.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)