Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NFT provenance tracker SDK - grant application #1832
NFT provenance tracker SDK - grant application #1832
Changes from 20 commits
54539ae
7eb647b
95e9b04
078ff6e
386691c
712a502
c149a02
b7958a8
d00beea
4cb1154
f0f24e7
1b78b64
fb90469
dd309db
353abda
2c6f348
86a7d32
e110196
d5f4cbe
48de46f
a18a3de
f8034ee
e7de5d9
95a4ad9
203dd05
89154da
d4f5c6f
018f097
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another research-leaning deliverable that I wouldn't support. Please focus on the deliverables, rather on activities - While I agree that you should have a well-defined model (rather than having non-typed js) I'd expect it the related code do be self-documenting by being clear and expressive and supplement it with inline-code where deemed necessary. Architectural diagrams or model diagrams can make sense here, too, however, I'd expect it to be part of the Documentation (0b.). To conclude, I suggest you remove this deliverable and incorporate it into the "Documentation" deliverable instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mandatory Docker deliverable is still missing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous, related inline comment still hasn't been addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mandatory Docker deliverable is still missing here.