Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFP/securityMarketPlace #1726

Merged
merged 11 commits into from
Jun 1, 2023
Merged

Conversation

ParthChaudhary31
Copy link
Contributor

@ParthChaudhary31 ParthChaudhary31 commented May 9, 2023

Project Abstract

Please replace these instructions with a brief description of your project summarising key points (1-2 paragraphs).

If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@CLAassistant
Copy link

CLAassistant commented May 9, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in our grants program. Could you update the formatting of the milestone tables? (see our template). The milestone tables should also specify the technical deliveries in a way that we can evaluate them. The FTE, for example, isn't something that we can double-check. Also are you aware of the following application: #1590

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label May 9, 2023
@ParthChaudhary31
Copy link
Contributor Author

ParthChaudhary31 commented May 9, 2023

Thanks for your interest in our grants program. Could you update the formatting of the milestone tables? (see our template). The milestone tables should also specify the technical deliveries in a way that we can evaluate them. The FTE, for example, isn't something that we can double-check. Also are you aware of the following application: #1590

I made the changes to the table as per requested and yes, We are aware of #1590 's proposal, They have proposed a solution entirely based on smart contracts while we abstracted a lot of functionalities and have proposed to solve them through node services to make the platform optimal for gas fees while also using smart contracts in only the most essential parts to keep the platform truly decentralized.

@ParthChaudhary31 ParthChaudhary31 changed the title RFP/security RFP/securityMarketPlace May 9, 2023
@semuelle semuelle self-assigned this May 10, 2023
@ParthChaudhary31 ParthChaudhary31 requested review from Noc2 and semuelle May 12, 2023 06:34
@ParthChaudhary31
Copy link
Contributor Author

@semuelle Are there any further pending changes you'd like us to update ?

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. However, all milestone tables should contain the default deliverables 0.a to 0.d (https://github.com/w3f/Grants-Program/blob/master/applications/application-template.md#milestone-1-example--basic-functionality) and your specific deliverables as 1, 2, etc. Also, your first milestone is usually not something that we support via our grants program since it's not useful for others. Finally, what do you mean by "finish the development of the front end and turn it into the interactive Front-End.". The specification of the milestone tables are the requirements of our contracts, so we need to be able to evaluate them. "Finish the front-end" could, for example, mean anything.

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthChaudhary31, to expand on what @Noc2 said: the architecture is something we usually expect the applicant to already have largely thought out, so M1 wouldn't be covered. And since we expect every milestone to come with the default deliverables, including tests, the third milestone doesn't work either.

I suggest you split M2 into two milestones, each with the default deliverables (tests, documentation, etc.) and remove M1 and M3. It would also be good to see how the smart contracts and backend interact with another, i.e. which data and functionality remains if the servers are shut down.

FYI, in your lifecycle description you speak only of smart contracts. The audits could be of any other project, though.

@ParthChaudhary31
Copy link
Contributor Author

Thanks for the update. However, all milestone tables should contain the default deliverables 0.a to 0.d (https://github.com/w3f/Grants-Program/blob/master/applications/application-template.md#milestone-1-example--basic-functionality) and your specific deliverables as 1, 2, etc. Also, your first milestone is usually not something that we support via our grants program since it's not useful for others. Finally, what do you mean by "finish the development of the front end and turn it into the interactive Front-End.". The specification of the milestone tables are the requirements of our contracts, so we need to be able to evaluate them. "Finish the front-end" could, for example, mean anything.

@Noc2 Thanks for your suggestions, we have updated the milestones accordingly and tried to make our deliverables more specific.

@ParthChaudhary31
Copy link
Contributor Author

@ParthChaudhary31, to expand on what @Noc2 said: the architecture is something we usually expect the applicant to already have largely thought out, so M1 wouldn't be covered. And since we expect every milestone to come with the default deliverables, including tests, the third milestone doesn't work either.

I suggest you split M2 into two milestones, each with the default deliverables (tests, documentation, etc.) and remove M1 and M3. It would also be good to see how the smart contracts and backend interact with another, i.e. which data and functionality remains if the servers are shut down.

FYI, in your lifecycle description you speak only of smart contracts. The audits could be of any other project, though.

@semuelle Thanks for your suggestions, we have updated the milestones accordingly.

We were also aware that audits can be of any kind and have altered our wording to make it more inclusive.

@ParthChaudhary31 ParthChaudhary31 requested review from Noc2 and semuelle May 31, 2023 11:46
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. The application looks much better now. I have two follow up questions:

  • Could you specify the ink smart contracts in more detail as part of the milestone table specification? These are the requirements of our contracts.
  • Could you define "We will deliver the completely integrated and working product." in more detail? Feel free to also reference your previous explanation here.

Finally one minor thing: You can remove "Example" after Milestones 1 and 2.

@ParthChaudhary31
Copy link
Contributor Author

Thanks for the update. The application looks much better now. I have two follow up questions:

  • Could you specify the ink smart contracts in more detail as part of the milestone table specification? These are the requirements of our contracts.
  • Could you define "We will deliver the completely integrated and working product." in more detail? Feel free to also reference your previous explanation here.

Finally one minor thing: You can remove "Example" after Milestones 1 and 2.

@Noc2
These are the smart contracts we'll be developing:

  1. Escrow Contract
  2. Reputation Token Contract
  3. Audit Directory
  4. Arbiters Contract

As per your suggestion, I will add the details in the milestone table specification. Also, I will specify the details of the Integrated and working product

@ParthChaudhary31 ParthChaudhary31 requested a review from Noc2 May 31, 2023 17:55
@keeganquigley
Copy link
Contributor

Thanks for the application @ParthChaudhary31 a couple of questions:

  • How do fewer smart contracts make it more decentralized? In my opinion, gas fees aren't typically an issue in our ecosystem, despite being more computationally expensive than substrate runtime weights.
  • What framework will you use to develop the front-end?
  • What kind of reputation token contract will you use? Is it based on say the OpenBrush PSP37 standard NFT? Or is it more of a Soul Bound Token (SBT)?

Thanks!

@Noc2 Noc2 added the ready for review The project is ready to be reviewed by the committee members. label Jun 1, 2023
keeganquigley
keeganquigley previously approved these changes Jun 1, 2023
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ParthChaudhary31, for your thorough answers and for reducing the price. I am happy to support it as well.

@ParthChaudhary31
Copy link
Contributor Author

Thanks for the update. As promised, I will mark it as ready for review, and I'm personally willing to go ahead with it. However, it might help to reduce the price. Currently, you need five approvals, and I'm not sure everyone will be willing to accept the current rate.

@Noc2 We'd really like to contribute to Polkadot's community as a firm and hence are willing to revise our price. As for the price per engineer, I have offered updated pricing, considering the current market, which would bring the grant amount down to $40,000 (~ $7k less than the last quote), if we remove all our margin we can further decrease the price to $36,500. Beyond this, we are working solely for the growth of the Polkadot community, Our final price after all consideration would be $29,920.

Noc2
Noc2 previously approved these changes Jun 1, 2023
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update.

Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. In general, I'm happy to approve as well, but could you change the grant level to 2 (instead of 3) since the final price is now less than $30k and it'll be easier to get 3 approvals than 5 approvals.

applications/Security_Marketplace.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthChaudhary31 ParthChaudhary31 dismissed stale reviews from Noc2 and keeganquigley via acf765f June 1, 2023 14:47
@ParthChaudhary31 ParthChaudhary31 requested a review from takahser June 1, 2023 14:49
@takahser takahser merged commit 1deb696 into w3f:master Jun 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at [email protected] and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

@ParthChaudhary31
Copy link
Contributor Author

Thank you very much @Noc2, @keeganquigley & @takahser for your vote of confidence, We are ecstatic to contribute to the community as a firm. We have aligned the team and kick-started the development process for milestone 1.

@ParthChaudhary31
Copy link
Contributor Author

@Noc2, @keeganquigley & @takahser,
As per my conversation with @semuelle at w3f/Grant-Milestone-Delivery#945, It's to inform you guys that whilst developing the smart contracts for the platform we felt that the deployment costs of the contract can be saved by merging the Audit Directory Contract's function into that the Escrow contract. We also felt that the functionality of the Arbiters Contract (voting by various arbiters on-chain) would have burdened our arbiters into paying the gas fees which could have proved a hurdle for them at times when we need their part to be fast and smooth so we dealt with that functionality on the back end and so we imposed these changes to the platform.

Can you guys approve of the same? , I'm also more than happy to answer any of your questions regarding the same.

@Noc2
Copy link
Collaborator

Noc2 commented Aug 9, 2023

@ParthChaudhary31, thanks for pinging us here. In this case, could you create a PR to update the original application?

@ParthChaudhary31
Copy link
Contributor Author

ParthChaudhary31 commented Aug 10, 2023

@ParthChaudhary31, thanks for pinging us here. In this case, could you create a PR to update the original application?

Sure thing, is there a standard process I need to follow for that? or should I create a new application PR for this with suggested amendments?

Also, if any of the team members feel discontent with the changes suggested,
We're also more than happy to go back to the original plan, it's just our suggestions on how we feel the platform can be more attractive for new users while also being more economically friendly.

@semuelle
Copy link
Member

is there a standard process I need to follow for that? or should I create a new application PR for this with suggested amendments?

Yeah, it's like the application PR, but instead of a new document, you just commit changes to the existing one.

@ParthChaudhary31
Copy link
Contributor Author

ParthChaudhary31 commented Aug 11, 2023

Raised a new PR here : #1901

@keeganquigley
Copy link
Contributor

Hi @ParthChaudhary31 is it possible to get an update on milestone 1?

@ParthChaudhary31
Copy link
Contributor Author

ParthChaudhary31 commented Sep 22, 2023

Hi @ParthChaudhary31 is it possible to get an update on milestone 1?

@keeganquigley We have submitted Milestone 1, you can check it out Here.

We're currently in the process of testing and optimizing Deliverables of milestone 2 and will raise a PR for the same by the starting week of next month.

@KennethkLopez
Copy link

Hey @ParthChaudhary31 & @semuelle are you guys in search of a Product Designer for the marketplace? Would love to chat on how I can contribute. Here's my website for reference.

Looking forward to connecting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants