-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stylograph #996
Stylograph #996
Conversation
Thanks for the delivery, @deep-ink-ventures. We will look into it as soon as possible. Please note that, since you submitted both milestones in one PR, we have to evaluate and approve both at the same. |
We have in the meantime added a few more meaningful plugins to showcase the features at genesis dao: A vesting wallet and escrow contract, can be seen in action here. |
Thanks for the info, @deep-ink-ventures. I started reviewing the milestones yesterday. I should have some meaningful feedback EOD tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deep-ink-ventures. Sorry for the long wait. I have gone through most of the deliverables, and everything looks pretty good.
Now I am trying the Genesis DAO Docker image you provided (not technically part of the milestone, but much easier to evaluate), and it seems the genesis-dao-service
isn't working. I cannot create a DAO, because the token balance call is returning a 404: ERROR fetchNativeTokenBalance errors - Assertion failed
. Any idea what the issue might be?
FYI, the repository link on crates.io leads to a 404: https://github.com/deep-ink-ventures/pallet-hookpoints/
Thank you Sebastian! We are currently adding a lot of updates to our chain and the service is actively changing as well, so as long as we are testnet this might happen :-)! We'll look into this beginning of this week and come back to you asap! We'll as well fix the link. |
@semuelle we fixed the link here: deep-ink-ventures/pallet_hookpoints@f339c73#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542L8 For the other error: We are not able to reproduce that, but our frontend engineer has a suspicion and fixed that. If it still occurs please provide us with the full stack trace. |
Thanks for the updates. The error is gone. I'm not sure if it's based on something you changed, but I can see that the |
In general terms the service is acting as a middleware between the node and the frontend. It listens to events and put them into a relational structure, so that it can answer things more straightforward that the frontend might need to know (things like "I'd like to show a chart of the historic balance"). Stay tuned on this, since we and everyone who launches an app does this everytime, we are doing some design drafts on how this could be abstracted away. Therefore:
So a |
Just leaving a quick update here: I have reviewed all of M1 now. Unless I run into any other issues, I will hopefully be able to finish M2 tomorrow as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @deep-ink-ventures. Sorry for the long wait. I am happy to report that both milestones are accepted. I appreciate the thorough documentation and seeing everything already in practice!
I have forwarded your invoice for processing. You can find the evaluation notes here and here.
FYI, the transactions page on genesis-dao.org is currently return a 500
for me right now. I am logged in as Alice, if you want to test it yourself.
Thank you, very much appreciated. Thanks as well for the error report, we are in the midst of upgrading to both v1.0.0 of polkadot and some chain improvements, and the service is currently upgrading. We're on it :-) |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1725