Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm-opt-for-rust-maintenance-9 #995

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

brson
Copy link
Contributor

@brson brson commented Sep 4, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1305

This month we received a big bug fix contribution -
we hadn't been compiling the binaryen DWARF passes at all,
and our tests completely missed this.
Nobody had noticed until now probably because our blockchain use cases are stripping DWARF.
A contributor found and fixed this problem, updated the tests so they don't regress,
and we released a new build.
The fix will increase the already notably bad build times sadly.

We also helped with a small cargo-contract regression and continued working on the upstream fixes for Windows Unicode support.

@semuelle semuelle self-assigned this Sep 5, 2023
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the delivery, @brson. Your milestone is hereby approved.

I have forwarded your invoice for processing.

@semuelle semuelle merged commit d12c5fd into w3f:master Sep 5, 2023
6 checks passed
@RouvenP
Copy link

RouvenP commented Sep 8, 2023

hi @brson we just transferred the payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants