Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotnix 2 evaluation #1202

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Dotnix 2 evaluation #1202

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
225007a
init file
PieWol Jul 25, 2024
b0cb274
eval done
PieWol Jul 30, 2024
39c3e3b
fix status
PieWol Aug 7, 2024
da1534f
update eval
PieWol Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 63 additions & 5 deletions evaluations/dotnix_2_piewol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,73 @@

| Number | Deliverable | Accepted | Link | Evaluation Notes |
| ------ | ----------- | :------: | ---- |----------------- |
| **0a.** | License | <ul><li>[ ] </li></ul> | [LICENSE](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/LICENSE) | MIT |
| **0b.** | Documentation | <ul><li>[ ] </li></ul> | [README](https://github.com/sporyon/dotnix-core/blob/9a0cc3705e10da23fb2743b1a2f76fd8f2c4c3c4/README.md) | — |
| **0c.** | Testing and Testing Guide | <ul><li>[ ] </li></ul> | [/checks](https://github.com/sporyon/dotnix-core/tree/470096931e56374ebc3fcc0af821dd774ef44d10/checks) | Testing guide see README. |
| **0d.** | Docker | <ul><li>[ ] </li></ul> | [docker.nix](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/docker.nix) | — |
| 1. | Audit Trail | <ul><li>[ ] </li></ul> | [trail](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/pkgs/list-dependencies.nix) | |
| **0a.** | License | <ul><li>[x] </li></ul> | [LICENSE](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/LICENSE) | MIT |
| **0b.** | Documentation | <ul><li>[x] </li></ul> | [README](https://github.com/sporyon/dotnix-core/blob/9a0cc3705e10da23fb2743b1a2f76fd8f2c4c3c4/README.md) | — |
| **0c.** | Testing and Testing Guide | <ul><li>[ ] </li></ul> | [/checks](https://github.com/sporyon/dotnix-core/tree/470096931e56374ebc3fcc0af821dd774ef44d10/checks) | Testing guide looks fine but doesn't work atm. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide details in what way the test does not work. Running nix flake check --print-build-logs should complete without an error (exit code 0) which indicates a successful test

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The testing guide didn't work for the docker setup. The regular tests were finishing without error thus passing.

| **0d.** | Docker | <ul><li>[ ] </li></ul> | [docker.nix](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/docker.nix) | following the instructions doesn't work |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide details which instructions you used, building it yourself or downloading it. What issues did you run into.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

building it myself. I didn't download the tarball manually. I think I mentioned this on your original delivery PR.

| 1. | Audit Trail | <ul><li>[ ] </li></ul> | [trail](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/pkgs/list-dependencies.nix) | doesn't work within docker |
| 2 | CLI Tool Development | <ul><li>[ ] </li></ul> | [CLI](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/nixosModules/polkadot-validator.nix) | — |
| 2a. | Functions| <ul><li>[ ] </li></ul> | [polkadot-validator.nix](https://github.com/sporyon/dotnix-core/blob/470096931e56374ebc3fcc0af821dd774ef44d10/nixosModules/polkadot-validator.nix) | — |


## General Notes
sadly the validator doesn't seem to work when trying to run it in Docker.
<details>

```
● polkadot-validator.service - Polkadot Validator
Loaded: loaded (/etc/systemd/system/polkadot-validator.service; linked; preset: enabled)
Active: activating (auto-restart) (Result: exit-code) since Tue 2024-07-30 22:52:36 UTC; 10s ago
Docs: https://github.com/paritytech/polkadot
Process: 514 ExecStart=/nix/store/88ikqbzkq5d7vnlj77l6gjbpw6ph23nx-polkadot-1.14.0/bin/polkadot --validator --name=dotnix-docker --chain=westend --base-pa>
Main PID: 514 (code=exited, status=1/FAILURE)
IP: 1.0K in, 780B out
CPU: 45ms
```
turns out that there seems to be an issue with setting the node key. Even after running
```
$ polkadot key generate-node-key | polkadot-validator --set-node-key
```
The shortened error output after running
```
$ journalctl -n 1000 -f -u polkadot-validator.service
```

```Jul 30 23:10:27 dfc0bf67828a systemd[1]: Started Polkadot Validator.
Jul 30 23:10:27 dfc0bf67828a polkadot[528]: Error:
Jul 30 23:10:27 dfc0bf67828a polkadot[528]: 0: Starting an authorithy without network key in /run/credentials/polkadot-validator.service/node_key.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide the exact commands you have entered after starting the docker image and the full journal? Entering just polkadot key generate-node-key | polkadot-validator --set-node-key should start the validator. This functionality has been implemented as part of the previous milestone and has not been touched since.

We could reproduce the issue by first generating the key with polkadot key generate-node-key | polkadot-validator --set-node-key which successfully starts the validator, and subsequently resetting the key to the empty string by running polkadot-validator --set-node-key and pressing enter, which will restart the validator into the broken state.

At the moment set node key will not check if the provided key is valid. This is something which needs improvement in the future.

```
</details>

## Audit Trail

somehow the given command is not recognized in the docker instance. Did I do something wrong setting up the docker instance?

```[root@dfc0bf67828a:~]# list-dependencies --runtime PATH
-bash: list-dependencies: command not found
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list-dependencies package was missing in the docker image it has been added in sporyon/dotnix-core@65e9520

```

## Testing
All tests are finishing

<details>

```
vm-test-run-list-dependencies> (finished: must succeed: list-dependencies --all /nix/store/axpdxi5n90bsh2l6pk0l2f5804v8bg63-mockdep-a | sort | sha256sum -c /nix/store/axdc284j54rqvfwlh1bq8v9japjcbp7g-all-dependencies.sha256sum, in 103.28 seconds)
vm-test-run-list-dependencies> alice: must succeed: list-dependencies --runtime /nix/store/axpdxi5n90bsh2l6pk0l2f5804v8bg63-mockdep-a | sort | sha256sum -c /nix/store/grx7vv5vg9n7y3qn9l4k9i2q7m18fjam-runtime-dependencies.sha256sum
vm-test-run-list-dependencies> alice # [ 104.644609] systemd[1]: Finished Networking Setup.
vm-test-run-list-dependencies> alice # [ 104.895981] systemd[1]: Starting Extra networking commands....
vm-test-run-list-dependencies> alice # [ 106.089879] systemd[1]: Finished Extra networking commands..
vm-test-run-list-dependencies> alice # [ 106.155521] systemd[1]: Reached target Network.
vm-test-run-list-dependencies> alice # [ 106.314988] systemd[1]: Starting Permit User Sessions...
vm-test-run-list-dependencies> (finished: must succeed: list-dependencies --runtime /nix/store/axpdxi5n90bsh2l6pk0l2f5804v8bg63-mockdep-a | sort | sha256sum -c /nix/store/grx7vv5vg9n7y3qn9l4k9i2q7m18fjam-runtime-dependencies.sha256sum, in 6.00 seconds)
vm-test-run-list-dependencies> (finished: run the VM test script, in 109.28 seconds)
vm-test-run-list-dependencies> alice # [ 107.865705] systemd[1]: Finished Permit User Sessions.
vm-test-run-list-dependencies> alice # [ 108.157429] systemd[1]: Started Getty on tty1.
vm-test-run-list-dependencies> alice # [ 108.239855] systemd[1]: Reached target Login Prompts.
vm-test-run-list-dependencies> test script finished in 110.66s
```
</details>