-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subcoin milestone 1 #1193
Subcoin milestone 1 #1193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @liuchengxu thanks for the delivery. I started the eval and have a few comments:
- Unit tests are all passing, thanks!
- Could you please add Docker instructions to the readme for clarity? I was able to build and run it successfully using
docker build -t subcoin-node --file ./Dockerfile .
anddocker run -d subcoin-node
but it exits immediately. Will it have more functionalities in future milestones? - How can I spin up the node (locally)? Usually after building it w/
cargo build --release
I am able to launch it with something like./target/release/subcoin-node --dev
but I'm having no luck.
Thanks for any help you can provide!
The installation instruction using Docker is here at https://github.com/subcoin-project/subcoin/blob/subcoin-milestone-1/docs/src/installation.md#docker-linuxamd64, the docker image has already been built via GitHub Action and hosted on GitHub, you don't have to make it on your own. The prebuilt executables are available on GitHub as well https://github.com/subcoin-project/subcoin/releases/tag/v0.1.0. Apart from the commands using the executable, Docker commands are now added in this commit subcoin-project/subcoin@9e509ef
Please check out this link in 0b in which every step to test the functions in this milestone has been elaborated @keeganquigley In addition, Subcoin provides a custom interface for CLI usage due to its uniqueness, so the experiences in other typical Substrate chains may not directly work in Subcoin, please do read the links carefully in the delivery. |
Thanks @liuchengxu for the changes, and also for linking the docs. I completely missed these additional docs, sorry! Everything is working now and I'm happy to pass the milestone. Here is my final evaluation. Cheers and looking forward to the next one. |
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion. |
@liuchengxu, the invoice must include your full name and address. Could you resend the invoice with the information added? Thanks! |
Hmm, the full name and address were both included in the invoice. Is it because the full name must match the one filled in KYC? Anyway, I already resend the invoice, the full name now is the same as the one in KYC, and unlike the last invoice in which the address was in the item section, the polkadot address is now attached to the Notes section. Let me know if it's fine this time. @semuelle |
Sorry. Not payment address, but postal address. |
We have your payment address. Swiss law requires that you also list your postal address. |
@semuelle Oops, sorry that I misread your last comment, the postal address was added and invoice resent again! |
hi @liuchengxu today we sent the USDT. The DOT payment follows this Friday. |
hi @liuchengxu we transferred the DOTs today |
Hey @RouvenP |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#2304