-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator Monitoring Service Milestone 2 #1155
Conversation
Not sure about the failed checks, please let me know if I need to change anything! |
Thanks @avtishin starting your evaluation now and I will look into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avtishin everything is working great so far and I am able to fire up the bot locally and in production. Here is my ongoing eval. I just have the two following notes:
- I'm not finding any unit tests or e2e tests for the python logic, can you point me to these if they exist?
- Typically we ask teams to provide a link for each milestone category, to easily find the code. I was able to find everything but would still be nice if you could add those.
Thanks!
Hey @keeganquigley, thanks for your evaluation and the excellent questions.
|
Thanks @avtishin for the explanations, much appreciated. I'm happy to pass the milestone, here is the final evaluation. Congrats! |
Please fill out the invoice form in order to initiate the payment process. Thank you! |
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch. For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action. |
@keeganquigley, thanks for your evaluation; we are happy you liked your project! As well as we will try to push it into the 1KV community because it seems the most suitable place. Also, today, we will make a PR that corrects spelling mistakes. |
hi @avtishin we just sent the payment |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1791