Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wasm-opt-for-rust-maintenance-10 #1023

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

brson
Copy link
Contributor

@brson brson commented Oct 3, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1305

We finally landed the long-promised fix for Unicode on Windows in upstream binaryen. It should appear in either release 116 or 117.

The fix we made last month for missing DWARF passes caused an unanticipated link-time regression for projects that also link to LLVM, since the DWARF passes reuse LLVM code, causing conflicting symbols. We have not decided on a fix yet.

Binaryen has released version 115 and 116. We will skip 115, and are working through some problems attempting the 116 upgrade.

There are two months remaining in this contract. I intend to fix the linkage regression, and get wasm-opt updated to the latest revisions of binaryen. I do not expect to have a solution for the cc rebuild times, as I don't have a plan yet that I am confident in, and the demand for it has been relatively subdued.

@semuelle semuelle self-assigned this Oct 4, 2023
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the delivery, @brson. I am happy to report that your milestone is accepted. You can find my evaluation notes here.

Your invoice is already being processed.

@semuelle semuelle merged commit dbb5556 into w3f:master Oct 4, 2023
6 checks passed
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants