-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dotly Milestone 1.md #1016
Dotly Milestone 1.md #1016
Conversation
broken links updated
Thanks for the delivery @justmert I updated the PR to include the original application pull request. Someone will take a look shortly. |
Hi @keeganquigley, is there any update about review? |
Apologies for the delay @justmert we have a bit of a backlog and some folks are out on holiday for a couple days this week, but someone will look at it soon. |
@justmert thank you for the milestone delivery. Please see the evaluation document and provide proper answers and fixes. After that, let me know when I can continue this evaluation. |
Hey @dsm-w3f, thanks for your review! Here is my answers to evalution document, if you need anything let me know. Frontend and Backend rate limit problem When I examine your first two backend and frontend problems, I see that you are getting a rate limit error. When you try again after a while, there will probably be no problem, but if it happens, let me know and I will see what I can do. This error is caused by the subscan api and will be resolved on its own after a certain period of time. External apis do not allow free use above a certain rate. Identity doesn't show This component will be updated soon, there was a confusion between my commits and they were not uploaded.
""Implement an endpoint for balance pie widget that displays three pie charts. The first pie chart will show parachain that account address has balance. The second pie displays distribution of balance like Transferrable balance, Locked balance etc. and the third pie chart will show sub-distribution balance of the first pie chart selection like Election Lock, Democracy Lock, etc."" I wrote the description this way, but I made it a clickable list because it created a confusing UI for mobile users and made the user experience difficult. You can think of it as Deliverable 4 and 5 combined.
I'm not sure I understand this question correctly, if that's not what you mean please tell me. It shows all tokens associated with the user's account, you can click on each token to view its details as I mentioned above.
Thanks for notifying that, there was a small mistake for related function's attribute, was showing the last 120 day. You can sum last 7 days and now it works correct!
Balance History: Since there are more components on the stats page than in the overview, I thought it would be better to show such general data in the overview section, so I moved it. Transaction Rate: Likewise, I added this data here because I thought it would appear more consistently on the extrinsics page. Thanks to you, I discovered a bug here because of that. However, if you want it to be on the pages specified in the milestone, I can easily move it to those pages.
Not right now, will publish in 2 days. Everything I said was solved has now been updated and live in the repos, you can try it. |
Hey @dsm-w3f, did you have a chance to look at my responses? |
@justmert thank you for the improvements and fixes. I think we still having problems in some parts of the application. Please see the details in the evaluation document. Let me know when I can continue this evaluation. The ideal situation is to fix and improve all points mentioned in the evaluation document before requesting a new evaluation round. |
Hey @dsm-w3f thanks for evaluation.
There was a problem with the types here, it has been fixed, I expect you to have no problems when you try again with the current version, but if it continues, please let me know.
Deliverable 6 and 8 have been placed where they should be, a new widget has been added for deliverable 4, you can check it from the current version.
Here is the article: https://medium.com/@kklmert/introduction-to-dotly-revolutionizing-polkadot-account-statistics-c3403f7766b3
I added docker to the backend and frontend separately. After the firebase stages for the backend are completed, it can be quickly run with docker. You can view the dotly-backend and dotly-frontend readmes to view the details. P.S: To try these new fixes, I recommend you to pull the repos from scratch. In order to avoid repetition while trying the backend, you can back up the dotly-admin-sdk.json you created during the backend stage and use the .env variables you have previously created with this file. Thanks |
@justmert thank you for the milestone delivery. I'm still having one problem with the frontend of the application. Please see the evaluation document for details. Let me know when I can check it again to finish this evaluation. |
Hey @dsm-w3f , thanks for evaluation. Frontend crashed because of a small condition, now solved. Also I've updated the frontend readme as with docker and without docker instructions. |
@justmert thank you for the improvements and fixes. The problem mentioned was fixed but now we have another one. Please see the evaluation document for details. We are almost finishing this evaluation. Let me know when I can check it again. |
@dsm-w3f there was a similar bug, now solved. Also backend readme updated, thanks for evaluation! |
@justmert thank you for the improvements and fixes. The milestone is approved. Please submit the invoice using the form in the message below. After that, the payment should take place within two weeks. Great job! |
🪙 Please fill out the invoice form in order to initiate the payment process. Thank you! |
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1784