Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotly Milestone 1.md #1016

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Dotly Milestone 1.md #1016

merged 2 commits into from
Oct 11, 2023

Conversation

justmert
Copy link
Contributor

@justmert justmert commented Sep 28, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1784

@keeganquigley
Copy link
Contributor

Thanks for the delivery @justmert I updated the PR to include the original application pull request. Someone will take a look shortly.

@justmert
Copy link
Contributor Author

justmert commented Oct 2, 2023

Hi @keeganquigley, is there any update about review?

@keeganquigley
Copy link
Contributor

Apologies for the delay @justmert we have a bit of a backlog and some folks are out on holiday for a couple days this week, but someone will look at it soon.

@dsm-w3f dsm-w3f self-assigned this Oct 2, 2023
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 3, 2023

@justmert thank you for the milestone delivery. Please see the evaluation document and provide proper answers and fixes. After that, let me know when I can continue this evaluation.

@justmert
Copy link
Contributor Author

justmert commented Oct 3, 2023

Hey @dsm-w3f, thanks for your review!

Here is my answers to evalution document, if you need anything let me know.

Frontend and Backend rate limit problem

When I examine your first two backend and frontend problems, I see that you are getting a rate limit error. When you try again after a while, there will probably be no problem, but if it happens, let me know and I will see what I can do.

This error is caused by the subscan api and will be resolved on its own after a certain period of time. External apis do not allow free use above a certain rate.

Identity doesn't show

This component will be updated soon, there was a confusion between my commits and they were not uploaded.

Where is the parachain balance pie chart? (Deliverable 4)

""Implement an endpoint for balance pie widget that displays three pie charts. The first pie chart will show parachain that account address has balance. The second pie displays distribution of balance like Transferrable balance, Locked balance etc. and the third pie chart will show sub-distribution balance of the first pie chart selection like Election Lock, Democracy Lock, etc.""

I wrote the description this way, but I made it a clickable list because it created a confusing UI for mobile users and made the user experience difficult. You can think of it as Deliverable 4 and 5 combined.

Do the parachain balance list only show the other balances if the account has other tokens?

I'm not sure I understand this question correctly, if that's not what you mean please tell me. It shows all tokens associated with the user's account, you can click on each token to view its details as I mentioned above.

Could you explain why The Weekly Transaction Rate is higher than the sum of the activity in the last week?

Thanks for notifying that, there was a small mistake for related function's attribute, was showing the last 120 day. You can sum last 7 days and now it works correct!

Screenshot 2023-10-03 at 22 42 52

Why did you move the Balance History chart to the Overview page and the Transaction Rate to Extrinsics?

Balance History: Since there are more components on the stats page than in the overview, I thought it would be better to show such general data in the overview section, so I moved it.

Transaction Rate: Likewise, I added this data here because I thought it would appear more consistently on the extrinsics page. Thanks to you, I discovered a bug here because of that.

However, if you want it to be on the pages specified in the milestone, I can easily move it to those pages.

Could you send me a print of the Google Analytics?

Screenshot 2023-10-03 at 22 13 29

Do you have some sketch of the article?

Not right now, will publish in 2 days.


Everything I said was solved has now been updated and live in the repos, you can try it.

@justmert
Copy link
Contributor Author

justmert commented Oct 5, 2023

Hey @dsm-w3f, did you have a chance to look at my responses?

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 6, 2023

@justmert thank you for the improvements and fixes. I think we still having problems in some parts of the application. Please see the details in the evaluation document. Let me know when I can continue this evaluation. The ideal situation is to fix and improve all points mentioned in the evaluation document before requesting a new evaluation round.

@justmert
Copy link
Contributor Author

justmert commented Oct 9, 2023

Hey @dsm-w3f thanks for evaluation.

I'm having problems with the backend. The Overview page isn't loading locally, and the tests for the Overview are failing. Check the Evaluation V1 for more info about this. Could you help me with this?

There was a problem with the types here, it has been fixed, I expect you to have no problems when you try again with the current version, but if it continues, please let me know.

About the Deriverable 4, I think it's better to do an amendment to change this and ajust the deriverables 6 and 8 in this amendment. If you remove a deliverable make sure to give us the dicount in the price since it was not developed.

Deliverable 6 and 8 have been placed where they should be, a new widget has been added for deliverable 4, you can check it from the current version.

Screenshot 2023-10-09 at 12 09 13

You said #1016 (comment) the article in 2 days will be published. You can add the link or send it to me when you do this.

Here is the article: https://medium.com/@kklmert/introduction-to-dotly-revolutionizing-polkadot-account-statistics-c3403f7766b3

About the Docker. Couldn't you instruct the user to create the .env with the information about the Firebase for the backend and the token for the frontend? Then instruct the user to build the image and launch the application.

I added docker to the backend and frontend separately. After the firebase stages for the backend are completed, it can be quickly run with docker. You can view the dotly-backend and dotly-frontend readmes to view the details.

P.S: To try these new fixes, I recommend you to pull the repos from scratch. In order to avoid repetition while trying the backend, you can back up the dotly-admin-sdk.json you created during the backend stage and use the .env variables you have previously created with this file.

Thanks

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 9, 2023

@justmert thank you for the milestone delivery. I'm still having one problem with the frontend of the application. Please see the evaluation document for details. Let me know when I can check it again to finish this evaluation.

@justmert
Copy link
Contributor Author

justmert commented Oct 9, 2023

Hey @dsm-w3f , thanks for evaluation. Frontend crashed because of a small condition, now solved. Also I've updated the frontend readme as with docker and without docker instructions.

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 10, 2023

@justmert thank you for the improvements and fixes. The problem mentioned was fixed but now we have another one. Please see the evaluation document for details. We are almost finishing this evaluation. Let me know when I can check it again.

@justmert
Copy link
Contributor Author

@dsm-w3f there was a similar bug, now solved. Also backend readme updated, thanks for evaluation!

@dsm-w3f
Copy link
Contributor

dsm-w3f commented Oct 11, 2023

@justmert thank you for the improvements and fixes. The milestone is approved. Please submit the invoice using the form in the message below. After that, the payment should take place within two weeks. Great job!

@dsm-w3f dsm-w3f merged commit 9375f2e into w3f:master Oct 11, 2023
3 checks passed
@github-actions
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@github-actions
Copy link

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants