Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Evaluation for ISO 8583 PoC - Milestone 1 #1003

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

stojanov-igor
Copy link
Contributor

External Evaluation ISO 8583 PoC

In general, most of the delivery is provided. I encountered some errors while building parts of the solution, so I expect these issues to be resolved before marking the delivery as Accepted. The issues can be resolved through code or documentation.

@stojanov-igor stojanov-igor mentioned this pull request Sep 18, 2023
6 tasks
@dastansam
Copy link
Contributor

dastansam commented Sep 18, 2023

  1. Installing interface dependancies was successful with some warnings.

warnings are displayed due to version mismatches in the dependencies, unfortunately, some of the packages I am depending are not actively maintained, so it won't be possible to fix the warnings.

  1. Starting the interface was not possible initially due to the following legacy issue:
    Removing the -openssl-legacy-provider solved the problem. Please resolve this issue.

thank you for the tip, I fixed the issue.

  1. Running the makefile fails with the following output:

Issue is with your local postgres server. Before I can address it I need to know if you are running postgres locally and if default values for the DB exist in your local setup.

  1. Running the docker container locally gives the following error:

Fixed and pushed

Could you publish your images to dockerhub, so we can download the pre-build images rather than building them locally?

Sure, here it is deployed

  1. The oracle tests were failing tho.

Same issue as 4

  1. Running the Oracle fails with similar error as the Makefile.

Same issue as 4

  1. Consider hosting the solution online for the second delivery. It makes everything much easier to test and validate the functionality without running everything locally.

I think it's a good idea, will definitely consider it. Or at least a docker-compose configuration with images deployed to DockerHub

@dastansam
Copy link
Contributor

Let's switch the discussion here @stojanov-igor.

Since you didn't have postgres server running locally, you encountered the above issues with the oracle. Let me know how it goes after you install postgres

thank you for your review

@stojanov-igor
Copy link
Contributor Author

I was able to install Postgres. However, I still have the same issue:

    Finished release [optimized] target(s) in 0.12s
Launching the Oracle
[2023-09-18T15:19:11Z INFO  pcidss_oracle] Starting PCIDSS Gateway Oracle
[2023-09-18T15:19:11Z INFO  pcidss_oracle] Connecting to Postgres database: postgres://postgres:postgres@localhost:5432/postgres
[2023-09-18T15:19:11Z INFO  op_core::postgres] Running migrations
[2023-09-18T15:19:11Z ERROR pcidss_oracle] Could not run migrations Error { kind: Connect, cause: Some(Os { code: 61, kind: ConnectionRefused, message: "Connection refused" }) }
make: *** [launch] Error 1

Let me know if I am missing something...

@dastansam
Copy link
Contributor

I was able to install Postgres. However, I still have the same issue:

    Finished release [optimized] target(s) in 0.12s
Launching the Oracle
[2023-09-18T15:19:11Z INFO  pcidss_oracle] Starting PCIDSS Gateway Oracle
[2023-09-18T15:19:11Z INFO  pcidss_oracle] Connecting to Postgres database: postgres://postgres:postgres@localhost:5432/postgres
[2023-09-18T15:19:11Z INFO  op_core::postgres] Running migrations
[2023-09-18T15:19:11Z ERROR pcidss_oracle] Could not run migrations Error { kind: Connect, cause: Some(Os { code: 61, kind: ConnectionRefused, message: "Connection refused" }) }
make: *** [launch] Error 1

Let me know if I am missing something...

are you sure postgres server is running? maybe it exposes a different port? or default database is not postgres? try setting DB variables for the oracle explicitly, with the arguments mentioned in the README

can you paste values of the following commands:

pg_isready

pg_ctl status

if it doesn't show /tmp:5432 - accepting connections or sth similar, you are not properly running postgres

@dastansam
Copy link
Contributor

in any case, Connection refused error is usually related to improperly configured postgres server. make sure it's running and default user postgres and db postgres are there. If it's not there and you are using other users, pass your DB configuration explicitly.

@dastansam
Copy link
Contributor

dastansam commented Sep 18, 2023

hey @stojanov-igor,

I think I solved your issue. I added a docker-compose file with Postgres Docker image, and now you don't need to have postgres installed to run the oracle.

Just docker-compose up and it should be running.

@stojanov-igor
Copy link
Contributor Author

Hi @dastansam,

Thank you for the prompt reply. The docker image worked for me.

I have updated the status of the delivery to Accepted. There are still some nice to have things that have to be implemented in the future, but I think you have fulfilled the requirements for Milestone 1.

The team at Web3 Foundation will also do their own evaluation, so I wish you good luck.

@nikw3f
Copy link
Contributor

nikw3f commented Sep 22, 2023

@stojanov-igor thank you for the external evaluation. It is accepted. I'll forward your KSM payment. Great job!

@nikw3f nikw3f merged commit d714073 into w3f:master Sep 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants