Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain to to get data without validation #563

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Oct 14, 2024

As discussed in #554, this PR adds an explainer text and a warning about how to read data from an InteractionOutput to skip validation.

Once the content of this PR is reviewed and accepted, a follow-up PR will add a threats and mitigation section, as asked in this comment.


Preview | Diff

Copy link
Contributor

@zolkis zolkis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at this stage, we can merge. Anyway this will need more work, e.g. defining algorithms for validation (without which we don't have validation anyway).

Copy link
Contributor

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment. Apart from that it looks good! Thanks!

index.html Outdated Show resolved Hide resolved
Co-authored-by: danielpeintner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants