Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription IDs to events #810

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add subscription IDs to events #810

wants to merge 1 commit into from

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Nov 8, 2024

@Mr0grog
Copy link

Mr0grog commented Nov 8, 2024

Is there any chance this could add a list of session.Subscription to every event, which would also help solve #754?

@OrKoN OrKoN force-pushed the orkon/subscribe branch 11 times, most recently from 1a496fc to 406879e Compare November 12, 2024 10:41
@OrKoN OrKoN marked this pull request as ready for review November 12, 2024 12:02
@css-meeting-bot
Copy link
Member

The Browser Testing and Tools Working Group just discussed Subscription IDs for events.

The full IRC log of that discussion <AutomatedTester> topic: Subscription IDs for events
<AutomatedTester> github: https://github.com//pull/810
<AutomatedTester> orkon: this is a continuation of the previous topic
<AutomatedTester> ... I have been reworking this to make sure that we can inherit events
<jgraham> q+
<AutomatedTester> ... I have tried to get all the use cases but I am not sure that I ahve got them all
<AutomatedTester> ... should we add subscription IDs or should we use the current way of doing it without IDs
<AutomatedTester> ack next
<AutomatedTester> jgraham: I like the subscription id approach is good
<AutomatedTester> ... jdescottes brought this up for when working on tests so we can unscribe from events that are not related to what we are wroking on. e.g. harness events vs user events
<AutomatedTester> ... <describes a use case where we subscribe events from a list and then diff them>
<AutomatedTester> ... it might be easier to have it just as a list of events we want to handle
<AutomatedTester> q?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants