Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail aborted navigation #800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fail aborted navigation #800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2933,8 +2933,9 @@ To <dfn>await a navigation</dfn> given |navigable|, |request|, |wait condition|,
"<code>download started</code>", "<code>navigation aborted</code>",
"<code>navigation failed</code>"» and |navigation id|.

1. If |event received| is "<code>navigation failed</code>"
return [=error=] with [=error code=] [=unknown error=].
1. If |event received| is "<code>navigation failed</code>" or
"<code>navigation aborted</code>" return [=error=] with [=error code=]
[=unknown error=].

Issue: Are we surfacing enough information about what failed and why with
an error here? What error code do we want? Is there going to be a problem
Expand Down