Update term definitions according to the core vocab #185
Conversation
decentralgabe
force-pushed
the
issue-182-term-defs
branch
from
c3e402e
to
b0a1bc3
Compare
There was a problem hiding this comment.
Unfortunately, that is incorrect... I propose to change the sentences as follows:
<p>
This term is part of the
<a href="https://www.w3.org/ns/credentials#JsonSchema2023">Verifiable Credentials Vocabulary v2.0</a>.
</p>
…
<p>
This term is part of the
<a href="https://www.w3.org/ns/credentials#VerifiableCredentialSchema2023">Verifiable Credentials Vocabulary v2.0</a>.
</p>I do not believe referring to the JSON-LD spec's term definition brings anything here, so I removed that reference, too.
Of course, the URL-s must be updated if the final term names change.
(GitHub does not let me propose a direct edit to the full sentence, hence this comment.)
index.html
Outdated
| @@ -155,7 +155,7 @@ <h2>Data Model</h2> | |||
| <h3>JsonSchema2023</h3> | |||
| <p> | |||
| This <a href="https://www.w3.org/TR/json-ld/#dfn-term-definition">term definition</a> | |||
| is <code>https://www.w3.org/TR/vc-json-schema/#JsonSchema2023</code>. | |||
| is <code>https://www.w3.org/TR/vc-json-schema#JsonSchema2023</code>. | |||
There was a problem hiding this comment.
The slashless URI gets a 302 Found redirect to the slashed URI, where the fragment does not resolve.
The text found in that document always reads as the mixed case JsonSchema2023, but the fragment identifier for the section where it is defined is the lowercase #jsonschema2023, where it says --
This term definition is https://www.w3.org/ns/credentials#JsonSchema2023.
-- which gets a 302 Found redirect to https://www.w3.org/ns/credentials/ which gets a 404 Not Found.
This is confusing to me, and I've been working with all this stuff for quite a while. It seems that anyone new to any of this material who encounters the above will quickly throw up their hands and walk away.
index.html
Outdated
| @@ -238,7 +238,7 @@ <h3>JsonSchema2023</h3> | |||
| <h3>VerifiableCredentialSchema2023</h3> | |||
| <p> | |||
| This <a href="https://www.w3.org/TR/json-ld/#dfn-term-definition">term definition</a> | |||
| is <code>https://www.w3.org/TR/vc-json-schema/#VerifiableCredentialSchema2023</code>. | |||
| is <code>https://www.w3.org/TR/vc-json-schema#VerifiableCredentialSchema2023</code>. | |||
There was a problem hiding this comment.
Similar to comments above on JsonSchema2023.
|
Sorry @TallTed and @decentralgabe I screwed up. The right URLs should be
ie: <p>
This term is part of the
<a href="https://www.w3.org/2018/credentials/#JsonSchema2023">Verifiable Credentials Vocabulary v2.0</a>.
</p>
…
<p>
This term is part of the
<a href="https://www.w3.org/2018/credentials/#VerifiableCredentialSchema2023">Verifiable Credentials Vocabulary v2.0</a>.
</p>Sorry about the confusion. |
|
updated |
@OR13, @decentralgabe, also with w3c/vc-data-model#1218, I believe this PR can be merged. |
Fix #182
Preview | Diff