Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require at least one JSON Schema version #184

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Require at least one JSON Schema version #184

merged 3 commits into from
Jul 31, 2023

Conversation

decentralgabe
Copy link
Collaborator

@decentralgabe decentralgabe commented Jul 25, 2023 •
edited by pr-preview bot
Loading

Fix #180

  • Require implementers support the latest json schema version
  • Add note around watching for the release of the 'stable' json schema version

Preview | Diff

@decentralgabe decentralgabe mentioned this pull request Jul 25, 2023
Open
iherman
iherman approved these changes Jul 26, 2023
View reviewed changes
index.html Outdated Show resolved Hide resolved
TallTed
TallTed requested changes Jul 26, 2023
View reviewed changes
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These include @iherman's not->NOT

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@decentralgabe @TallTed
Apply suggestions from code review
c5e25d7 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@decentralgabe decentralgabe merged commit 2d2615f into main Jul 31, 2023
1 check passed
@decentralgabe decentralgabe deleted the issue-180-required-schema branch July 31, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed requested changes

@iherman iherman iherman approved these changes

@andresuribe87 andresuribe87 andresuribe87 approved these changes

@OR13 OR13 OR13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require all implementers to support at least one common JSON Schema version
5 participants
@decentralgabe @iherman @andresuribe87 @TallTed @OR13