Added related resource text and example #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
index.html
Outdated
| @@ -441,6 +442,37 @@ <h3>Integrity Validation</h3> | |||
| <p class="issue" data-number="143"> | |||
| Provide examples for Data Integrity and VC-JWT Credential Schemas | |||
| </p> | |||
| <p> | |||
| The integrity of Credential Schemas of type <a href="#verifiablecredentialschema2023">JsonSchema2023</a> MAY | |||
There was a problem hiding this comment.
this should be amended to apply to both JsonSchema2023 and VerifiableCredentialSchema2023, other examples should be updated too.
There was a problem hiding this comment.
VerifiableCredentialSchema2023 already includes integrity guarantees being that it's a secured message. For what use cases are you thinking this would be useful?
Co-authored-by: Gabe <[email protected]>
decentralgabe
approved these changes
Jul 17, 2023
OR13
approved these changes
Jul 18, 2023
Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
@TallTed do you have any additional concerns that I can address in this PR? |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #120
Preview | Diff