Adding the jsonSchema property to the vocabulary #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iherman
requested review from
msporny,
OR13,
selfissued,
decentralgabe and
awoie
as code owners
decentralgabe
approved these changes
Sep 6, 2023
TallTed
requested changes
Sep 6, 2023
There was a problem hiding this comment.
Substantial tweaks to the diagram description, trying to make the language and presentation order consistent throughout, so it will be easier for a visually impaired person, for instance, to consume via an enunciator. Also switched some en-uk to en-us, to conform with W3 style. There may be additional changes needed, which will be much easier to see and request once all current change requests have been acted upon.
OR13
approved these changes
Sep 7, 2023
All of Ted's changes Co-authored-by: Ted Thibodeau Jr <[email protected]>
|
Thanks, @TallTed. I was hoping you would do that... (It is hard to create those descriptions...) |
TallTed
approved these changes
Sep 7, 2023
|
Multiple editorial reviews, changes accepted, over a week. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the counterpart, in the VCDM vocabulary, of w3c/vc-json-schema#211. The diagram, and its alt-text description, has also been adapted.
See the preview of the generated vocab