Strip "function anonymous" prefixes from Function samples #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
added a commit
to lukewarlow/WebKit
that referenced
this pull request
Jul 29, 2024
https://bugs.webkit.org/show_bug.cgi?id=277258 Reviewed by NOBODY (OOPS!). This strips "function anonymous" and similar prefixes for the function variants from the CSP violation report sample produced by trusted types. This aligns with Chromium's existing behaviour and the latest spec consensus. Spec PR: w3c/trusted-types#539 * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy-mutate.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-default-policy.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-csp-tt-no-default-policy.html: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/trusted-types/eval-function-constructor.html: * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowMissingTrustedTypesForSinkGroup const):
github-actions bot
added a commit
that referenced
this pull request
Sep 10, 2024
SHA: 3b74745 Reason: push, by lukewarlow Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lukewarlow
added a commit
to lukewarlow/WebKit
that referenced
this pull request
Dec 16, 2024
https://bugs.webkit.org/show_bug.cgi?id=277258 Reviewed by NOBODY (OOPS!). This strips "function anonymous" and similar prefixes for the function variants from the CSP violation report sample produced by trusted types. This aligns with Chromium's existing behaviour and the latest spec consensus. Spec PR: w3c/trusted-types#539 * LayoutTests/imported/w3c/web-platform-tests/content-security-policy/reporting/report-clips-sample.https-expected.txt: * Source/WebCore/page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::allowMissingTrustedTypesForSinkGroup const):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #491
cc @koto @otherdaniel
Preview | Diff