Post TPAC Update #22
Merged
Post TPAC Update #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At TPAC, we discussed a few changes to this spec: 1. Using "filterData" instead of enumerating a list of ad identifiers. For now, the proposal was to use the simplest approach of a single integer. 2. Storing information in the impression store about the script which invoked the saveImpression API, which might be a 3rd party script, and might be within an iframe. This could later be used for impression filtering and in the future, as a breakdown key. 3. Providing the maximum conversion value to the device in the saveImpression call as it will be used to deduct appropriate privacy budget loss.
martinthomson
approved these changes
Oct 1, 2024
| @@ -482,13 +483,11 @@ The arguments to <a method for=PrivateAttribution>saveImpression()</a> are as fo | |||
| [=impression=] with a subsequent [=conversion=], the [=conversion value=] | |||
| will be added to the histogram bucket identified by this index. | |||
| </dd> | |||
| <dt><dfn>ad</dfn></dt> | |||
| <dt><dfn>filterData</dfn></dt> | |||
There was a problem hiding this comment.
I wonder whether we might find a different name for this. Issue?
Comment on lines
+613
to
+616
| The maximum [=conversion value=] across all contributions included in the aggregation. | ||
| Together with epsilon, this is used to calibrate the distribution of random noise that | ||
| will be added to the outcome. It is also used to determine the amount of [=privacy budget=] | ||
| to expend on this [=conversion report=]. |
There was a problem hiding this comment.
I wonder whether we should set this to value if unspecified. That means that we'd need something else. I'd need to research how to do that properly within WebIDL though... Issue?
Comment on lines
+626
to
+627
| A list of sites which called the [=saveImpression=] API. Only [=impressions=] recorded by scripts originating from one of the | ||
| intermediary sites are eligible to match this [=conversion=]. |
There was a problem hiding this comment.
We need to connect this to the "iframe site domain" piece better than this does presently. Issue?
Co-authored-by: Martin Thomson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At TPAC, we discussed a few changes to this spec: