Some followup changes regarding epochs #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
reviewed
Apr 3, 2025
| but retaining browsing history, | ||
| a [=user agent=] can [=map/set=] the value | ||
| in the [=privacy budget store=] to 0 for all [=epochs=] | ||
| for all affected [=sites=]. | ||
|
|
||
| When clearing site data at the request of a [=site=], | ||
| through the use of the [:Clear-Site-Data:] header, |
There was a problem hiding this comment.
Do we need to address the points from #125 (comment)?
There was a problem hiding this comment.
I think that the discussion there suggests - to me at least - that we need to keep that issue open and do a little more work. This is probably enough for now, given that.
martinthomson
commented
Apr 3, 2025
csharrison
reviewed
Apr 7, 2025
Co-authored-by: Charlie Harrison <[email protected]>
csharrison
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at @csharrison here for a review.
I threw in a fix for #125 with this as a bonus.
Preview | Diff