-
Notifications
You must be signed in to change notification settings - Fork 7
Change name of filterData
to something better?
#24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree that |
@apasel422, sorry that you missed the meeting yesterday, but not surprised given the hour. In that, I suggested that the best extensibility strategy was to add new fields, rather than try to mutate existing ones. With that in mind, an integer value that we call something really simple might be better. Keep Bikeshed time:
The suggestion box is open. |
That's valid, though of course it means we need to determine what happens when multiple fields are present (which can be as simple as throwing).
I think we should try to avoid
These are certainly vague enough, but if we do add fields in the future for other types, what do we think the naming relationship will be? |
Flagging for discussion: this seems like it might need some wider input. It's very much a bikeshed, but the editors don't have a great set of choices here and maybe someone can help us. |
Another option is |
How about "matchValue"? It is about identifying a subset of values with a matching value.
I'd be careful with "tag" which is commonly used within AdTech and could lead to confusion. |
Discussed by a small group of mostly-very-tired individuals 2025-05-13: tentative conclusion is to take Brian's suggestion of |
This name was taken from the ARA spec. As of #22, which introduced it, it's just an integer. So perhaps "filterData" is not the best name for it.
As described, it's a very simple filtering mechanism, only ads and conversions with the same value for "filterData" can match for attribution purposes.
The text was updated successfully, but these errors were encountered: