Define an algorithm for launching a web app #1056

alancutter · 2022-10-28T05:03:52Z

This is in service of: WICG/web-app-launch#67

This change (choose at least one, delete ones that don't apply):

Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)

Commit message:

This change adds an algorithm for launching a web app to be used by manifest features that invoke launches like shortcut items, share target, file handling etc. This is also intended to be a point for https://wicg.github.io/web-app-launch/#launching-a-web-app to replace the behaviour with something that can re-use existing web app instances.

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

chore:
editorial:
BREAKING CHANGE:
And use none if it's a normative change

Preview | Diff

alancutter · 2022-10-28T05:11:21Z

Seems like the Node CI failed with The W3C_API_KEY input is required with VALIDATE_PUBRULES. Maybe I need to set up something in my fork?

index.html

marcoscaceres · 2022-10-28T05:32:09Z

index.html

+          <li>Let |client| be the result of
+              <a href="https://html.spec.whatwg.org/multipage/browsers.html#creating-a-new-top-level-browsing-context">
+              creating a new top-level browsing context</a>.
+          </li>


Suggested change

<li>Let |client| be the result of

<a href="https://html.spec.whatwg.org/multipage/browsers.html#creating-a-new-top-level-browsing-context">

creating a new top-level browsing context</a>.

</li>

<li>Let |client| be the result of

<a data-cite="html#creating-a-new-top-level-browsing-context">

creating a new top-level browsing context</a>.

</li>

We should speak to the HTML folks about this... if we need "creating a new top-level browsing context" to be exported, we should get them to do that (and they can sanity check this).

Sounds good. Filed: whatwg/html#8449

They are going to export "creating a new top-level traversable" soon that this can use: whatwg/html#8449 (comment)

Rebased onto the new html concepts. Note that main branch now has ReSpec errors: #1061

index.html

marcoscaceres · 2022-10-28T05:37:20Z

Seems like the Node CI failed with The W3C_API_KEY input is required with VALIDATE_PUBRULES. Maybe I need to set up something in my fork?

I'll have a look. Don't worry too much about the CI errors - I'll deal with them.

index.html

alancutter · 2022-11-03T23:58:55Z

Updated with suggestions from @mgiuca.

alancutter · 2022-11-06T23:44:29Z

I'll have a look. Don't worry too much about the CI errors - I'll deal with them.

Nvm I had a spec error, it's passing now.

index.html

alancutter · 2022-11-07T04:18:40Z

As discussed offline with @mgiuca I will:

Add prose stating the launch algorithm can be replaced by another algorithm.
Extract creating a new client out to a separate algorithm so the replacing algorithm can still use it.

mgiuca

LGTM, with changes discussed offline.

alancutter · 2022-11-07T06:09:17Z

Requested changes made, giving @marcoscaceres a chance to review and add comments before landing.

SHA: a0808b8 Reason: push, by alancutter Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

…er behaviors (#79) This builds on top of w3c/manifest#1056 which adds a launch web application algorithm to the manifest spec. This updates the launch handler spec to replace that algorithm with its own. This enables other webapp specs (not in WICG) to gain the launch_handler behaviour without directly referencing this WICG spec. Additionally this replaces the concept of "web app launch client" with the existing "application context" concept from the manifest spec which is effectively the same thing. #67 #69 #84 #79

alancutter requested a review from mgiuca October 28, 2022 05:06

alancutter force-pushed the launch-web-app branch 2 times, most recently from d618f09 to 6c942c8 Compare October 28, 2022 05:19

marcoscaceres reviewed Oct 28, 2022

View reviewed changes