Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to publish first draft. ReSpec tooling and sample content #20

Merged
merged 11 commits into from
Dec 11, 2024

Conversation

hzbarcea
Copy link
Contributor

@hzbarcea hzbarcea commented Dec 2, 2024

No description provided.

@hzbarcea hzbarcea requested a review from pchampin December 2, 2024 03:22
@hzbarcea
Copy link
Contributor Author

hzbarcea commented Dec 2, 2024

I need to fight formatting a bit more, to make it more compact.

Copy link
Member

@acoburn acoburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting comment

README.md Outdated Show resolved Hide resolved
@pchampin pchampin mentioned this pull request Dec 2, 2024
Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of comments/advices on using Respec.

* Technical: related to infrastructure tasks (e.g., "As a Service Provider, I want the ability to archive LWS storages").
Spike: used to explore or research an unknown aspect of the project (e.g., "Research what Identity System supports delegation.").

## How to build this spec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to simplify this section; most people (that is, everyone except editors, really) won't need to run respec manually, they will simply let the browser do the rendering.

What they need to do is

  • run a local http server (with npm as documented below, or with python3 -m http.server without anything to install)
  • then visit http://localhost:8080/spec/index.html

Let's not make the README overly intimidating :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Point taken. I thought about it as well, and the question indeed, is what the purpose of the README is. I will not make a change yet, but immediately after merging this PR I will split a BUILD.md out of the README and put the respec related pieces there. We still need to clarify what the audience for the README is and what content fits there @pchampin. Thanks!

copyrightStart: "2024",
// previousPublishDate: "N/A",
editors: [
{ name: "Pierre-Antoine Champin" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to help as staff contact, but I'd rather not commit to take editor's responsibilities, at least for in the short term.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pchampin agree, but you created the skeleton and your name was there. Please feel free to add a PR to remove or, better, leave it there knowing the limitation of responsibilities you made clear.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me, @pchampin qualifies for author, as skeleton creator. This does not imply any future responsibilities.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Show resolved Hide resolved
spec/user-stories.md Outdated Show resolved Hide resolved
spec/glossary.md Outdated Show resolved Hide resolved
@pchampin
Copy link
Contributor

pchampin commented Dec 5, 2024

@hzbarcea please also note that, as an editor, you should be able to push a branch directly on this repo, and make a PR from there. You do not need to work from a fork of this repo.

hzbarcea and others added 9 commits December 5, 2024 10:17
Co-authored-by: Aaron Coburn <[email protected]>
Co-authored-by: Pierre-Antoine Champin <[email protected]>
Co-authored-by: Pierre-Antoine Champin <[email protected]>
Co-authored-by: Pierre-Antoine Champin <[email protected]>
Co-authored-by: Pierre-Antoine Champin <[email protected]>
Co-authored-by: Pierre-Antoine Champin <[email protected]>
Co-authored-by: Pierre-Antoine Champin <[email protected]>
Co-authored-by: Pierre-Antoine Champin <[email protected]>
Co-authored-by: Pierre-Antoine Champin <[email protected]>
@hzbarcea
Copy link
Contributor Author

hzbarcea commented Dec 9, 2024

@hzbarcea please also note that, as an editor, you should be able to push a branch directly on this repo, and make a PR from there. You do not need to work from a fork of this repo.

Of course I am aware of this. It's easier for me to manage branches on a fork and keep the spec repo clean (and small) as much as possible. We can have branches on the spec to explore alternatives, but as far as working branches go, they belong more on forks, in my experience and habits. Not a biggie either way, you're obviously right.

Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more fix to the first "data-include" section, but overall LGTM

spec/index.html Outdated Show resolved Hide resolved
Co-authored-by: Pierre-Antoine Champin <[email protected]>
@hzbarcea hzbarcea merged commit 3141428 into w3c:main Dec 11, 2024
1 check passed
@hzbarcea hzbarcea deleted the first-draft branch December 11, 2024 20:28
@hzbarcea hzbarcea mentioned this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants