Activation conditions and child entry indices #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the glyph segmentation util.
… patches to the encoder.
… bytes of a segmentation.
Previously we automatically inserted anything not covered in another segment into the base segment. Going forward it's expected that the layer above will correctly specify the glyph segmentation, including the initial font subset definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for configuring the encoder with generic activation conditions for glyph keyed patches. Conditions can be of the form if (p1 or ... or ...) and (...) and ... then load pn. The previously available functionality for optional features has been reworked to use the new general framework.
Additionally serialization support has been added for writing a patch map using activation conditions via the child entry indices mechanism (see: w3c/IFT#252).
Lastly, this PR also updates the glyph segmentation util to make use of the new condition functionality in the test encodings it produces.