Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(css‑variables): Simplify var() function syntax definition #3485

Merged
merged 1 commit into from
Feb 8, 2019
Merged

refactor(css‑variables): Simplify var() function syntax definition #3485

merged 1 commit into from
Feb 8, 2019

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jan 5, 2019 •
edited
Loading

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Jan 5, 2019

Marked as non substantive for IPR from ash-nazg.

@ExE-Boss ExE-Boss mentioned this pull request Jan 7, 2019
Merged
@zcorpan
Copy link
Member

zcorpan commented Jan 21, 2019

LGTM but I'll leave this to @tabatkins

@ExE-Boss ExE-Boss mentioned this pull request Feb 6, 2019
Merged
@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Feb 7, 2019

Well, @tabatkins has approved this in mdn/data#353 (comment).

@zcorpan zcorpan requested a review from tabatkins February 7, 2019 13:28
@tabatkins tabatkins merged commit c95c7cc into w3c:master Feb 8, 2019
@ExE-Boss ExE-Boss deleted the css-variables-1/simplify-var-function-definition branch February 8, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewilligers ewilligers ewilligers approved these changes

@tabatkins tabatkins Awaiting requested review from tabatkins

Assignees

@tabatkins tabatkins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ExE-Boss @zcorpan @ewilligers @tabatkins