Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make aria-relevant and ariaRelevant reflect #2326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sideshowbarker
Copy link

@sideshowbarker sideshowbarker commented Sep 1, 2024

The ariaRelevant IDL attribute seems to have been intentionally commented out from the ARIAMixin interface in 646f093 — without any explanation that I could find, including not in the related issue at #1058.

But since at https://w3c.github.io/aria/#idl-reflection-attribute-values the spec says:

All ARIA attributes reflect in IDL as nullable DOMString attributes.

…and since there’s a test case included in http://wpt.live/html/dom/aria-attribute-reflection.html, and WebKit, Gecko, and Blink all pass that test — then it seems ariaRelevant needs to be included in ARIAMixin in the spec.

  • "author MUST" tests: N/A
  • "user agent MUST" tests: http://wpt.live/html/dom/aria-attribute-reflection.html
  • Browser implementations (link to issue or commit):
    • WebKit: Already implemented to reflect
    • Gecko: Already implemented to reflect
    • Blink: Already implemented to reflect
  • Does this need AT implementations?
  • Related APG Issue/PR:
  • MDN Issue/PR:

Preview | Diff

Copy link

netlify bot commented Sep 1, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 33712f9
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/66d3da647e8f8e000846b27c
😎 Deploy Preview https://deploy-preview-2326--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@w3cbot

This comment was marked as outdated.

@sideshowbarker sideshowbarker changed the title [aria] Make aria-relevant get reflected as ariaRelevant [aria] Make aria-relevant and ariaRelevant reflect Sep 2, 2024
@rahimabdi
Copy link
Contributor

rahimabdi commented Sep 4, 2024

Thank you for raising this, @sideshowbarker!

In addition to the WPT test confirming reflection, I am indeed seeing ariaRelevant in the accessibility WebIDL definition files for the 3 major browsers:

@cookiecrook had raised a newer related issue describing the general challenges with reflecting this attribute which was why it was removed: #1267.

I'll assign this one to myself to discuss at a future ARIA WG meeting.

@rahimabdi rahimabdi self-assigned this Sep 4, 2024
@rahimabdi rahimabdi added Agenda and removed Agenda labels Sep 4, 2024
@pkra pkra changed the title [aria] Make aria-relevant and ariaRelevant reflect Make aria-relevant and ariaRelevant reflect Sep 4, 2024
@pkra pkra added the spec:aria label Sep 4, 2024
@spectranaut
Copy link
Contributor

Discussed today's aria working group meeting during triage: https://www.w3.org/2024/09/05-aria-minutes#t02

@cookiecrook
Copy link
Contributor

cookiecrook commented Sep 5, 2024

I am indeed seeing ariaRelevant in the accessibility WebIDL definition files for the 3 major browsers

Yes, since this reflects the current reality, let's approve it.... In the meeting this morning I suggested, "revisit after the ongoing IDL discussions resolve," (so @spectranaut added the Do Not Merge label) but since all 3 engines are already shipping it, this is okay to merge as-is, IMO.

@rahimabdi rahimabdi self-requested a review September 21, 2024 22:24
@rahimabdi
Copy link
Contributor

I think the table in Section 10.2 ARIA Attribute Correspondence also needs updating.

Copy link
Contributor

@spectranaut spectranaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sideshowbarker -- thanks for this, can you update the table here too: https://w3c.github.io/aria/#accessibilityroleandproperties-correspondence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants