Add UI for Required Reports Phase update #774
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before the associated reports were all marked as final (but the tests were 100% done in the Test Queue)
* Refine raise an issue behavior * Address feedback * Fixed squished dot icon * Address last feedback * Hide closed issues on datamgmt page
* First pass on functioning sort buttons for DataManagePage * Functioning sort * Filter functionality for DataManagement * Refactor filter buttons on DataManagement to reduce complexity * Filter buttons as separate component * DataManagement page, break sort out into dedicated hook * DataManagement page, dedicated hook for filtering * DataManagement, add constant for test plan version phases to simplify hooks code * Add relevant dynamic aria attributes to DataManagement column sort elements * Add relevant dynamic aria attributes to DataManagement filter buttons * unit tests for SortableTableHeader * unit tests for FilterButtons * unit tests for useDataManagementTableSorting hook * Add unit tests for useDataManagementTableFiltering hook * Filter buttons only show buttons that have have label, handle testPlans with multiple versions, ... useDataManagementTableFiltering don't generate label for buttons that have no associated plans * Break out overall phase derivation logic into dedicated hooks, functional filter and sort * Simplify useDerivedTestPlanOverallPhase * Additional unit tests for additional hooks and to test scenarios with multiple test plan versions for a single test plan hook rename * Different UX click interaction sequence with SortableTableHeader * Correct interpretation of alphabetical ascending/descending * Rename DataManagement/hooks.js to filterSortHooks * Move sorting and filtering enums to more specific locations based on use * Fix file locations in unit tests, DataManagement, FilterButtons, SortableTableHeader * Smaller margin between buttons, FilterButtons * First pass on functioning sort buttons for DataManagePage * Functioning sort * Filter functionality for DataManagement * Refactor filter buttons on DataManagement to reduce complexity * Filter buttons as separate component * DataManagement page, break sort out into dedicated hook * DataManagement page, dedicated hook for filtering * DataManagement, add constant for test plan version phases to simplify hooks code * Add relevant dynamic aria attributes to DataManagement column sort elements * Add relevant dynamic aria attributes to DataManagement filter buttons * unit tests for SortableTableHeader * unit tests for FilterButtons * unit tests for useDataManagementTableSorting hook * Add unit tests for useDataManagementTableFiltering hook * Filter buttons only show buttons that have have label, handle testPlans with multiple versions, ... useDataManagementTableFiltering don't generate label for buttons that have no associated plans * Break out overall phase derivation logic into dedicated hooks, functional filter and sort * Simplify useDerivedTestPlanOverallPhase * Additional unit tests for additional hooks and to test scenarios with multiple test plan versions for a single test plan hook rename * Different UX click interaction sequence with SortableTableHeader * Correct interpretation of alphabetical ascending/descending * Rename DataManagement/hooks.js to filterSortHooks * Move sorting and filtering enums to more specific locations based on use * Fix file locations in unit tests, DataManagement, FilterButtons, SortableTableHeader * Smaller margin between buttons, FilterButtons * Cleanup after rebase * Render SortableTableHeader inside <table> for test to dismiss warning * Add AriaLiveRegionProvider, Update DataManagement table to use it * Allow SortableTableHeader component to work without AriaLiveRegionProvider
* Start to support for sunset phase * Explicitly use 'DEPRECATED' phase for TestPlanVersion.phase * Add checks to prevent test plan versions in R&D or Deprecated from being shown in data management dropdown * Remove duplicate updateTestPlanVersion call * Reuse phase variable * Add copy for deprecated reports with DisclaimerInfo component * Exclude 'DEPRECATED' testPlanVersions on DataManagement page query
* Adjust cell items for data management row to use list-related roles; update aria-labels * Address PR feedback * Remove width:max-content * Address PR feedback * Formatting * Address feedback
…the parent container
* Revise required reports approach * Update tests * Revert dev.env
* Apply correct sort order for Timeline for All Versions section * Update headings used on Versions page * Add aria-labelledby's for tables * Add for applicable spaces so the text is properly announced by NVDA * Add migration to add missing deprecatedAt dates and to also properly set the candidatePhaseReachedAt dates to more practical dates after the migrations (if candidatePhaseReachedAt < draftPhaseReachedAt, set it candidatePhaseReachedAt to draftPhaseReachedAt + 1day) * Test Plan Versions Page: Use standard testPlanVersions descending sort and show all phases being included in Version Summary * Switch issues search support for checking against hidden body content instead * Fix TestPlanReportStatusDialog using d (day of the week) and y (era) * Explicit check for older date when deprecating existing RD test plan versions during import * Update hidden message content in github issue * Update query for anon user on TestRun page * Keep overall status pill from drifting to center of cell * Fix R&D only TestPlanVersion's table not being shown * Use aria-label for heading to prevent space being announced
…ase with old TestPlanVersion results (#771) * Revise deprecation process when copying results from earlier version to avoid unexpected errors * Additional edge case management for updatePhaseResolver during copying of old test results * Address edge cases during phase update process when using old results * Update tests to include updatePhase process * Extend default timeout * Make db docs consistent between test and dev * Update database.md formatting --------- Co-authored-by: alflennik <[email protected]>
# Conflicts: # client/components/DataManagement/queries.js # client/components/ManageTestQueue/index.jsx # client/components/common/PhasePill/index.jsx # client/tests/__mocks__/GraphQLMocks/DataManagementPagePopulatedMock.js # client/tests/__mocks__/GraphQLMocks/TestQueuePageAdminPopulatedMock.js # client/tests/__mocks__/GraphQLMocks/TestQueuePageTesterPopulatedMock.js # server/graphql-schema.js # server/resolvers/index.js
|
@Paul-Clue this should be ready for you to pull whenever you're ready again! |
howard-e
requested changes
Oct 4, 2023
There was a problem hiding this comment.
@Paul-Clue thanks, I'm super impressed with the work to include this component and verified it does work as expected!
I think there are minor usability items I found and other nitpicks in code enhancements I've suggested below.
Another suggestion I had was with the edit button when clicked. Can the AT and Browser fields in the modal already be populated with the values of the row being click?
|
An additional observation I had here is that while going through the
I definitely think it's time to split these up into separate components in a follow up enhancement issue. cc @alflennik |
alflennik
approved these changes
Oct 5, 2023
howard-e
reviewed
Oct 5, 2023
howard-e
approved these changes
Oct 5, 2023
stalgiag
requested changes
Oct 17, 2023
server/resolvers/RequiredReportOperations/updateRequiredReportResolver.js
Show resolved
Hide resolved
stalgiag
reviewed
Oct 17, 2023
|
Hi @Paul-Clue sorry for the late notice on this bug, but I noticed an issue on mobile or small screen devices with one of the dropdowns. When there's not enough space for the contents of the dropdown, it will push the disclosure triangle out of the dropdown box, and it will wrap even though it feels like it should remain in its box. Hopefully the screenshots illustrate that. 
Also, I got the following error when I tried to use the dropdowns, it might be related to missing a browser field in the queries. 
Let me know when this is fixed, as well as the conflicts. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #683
The purpose of this PR is to enable admins to edit the requirements for updating the phase for testPlanVersions. I added the dropdown for editing the requirements on the data management page and the test queue page.