Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Routable Locations when Navigating Through Test Plan Tasks #372

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use Routable Locations when Navigating Through Test Plan Tasks #372

wants to merge 4 commits into from

Conversation

jkva
Copy link
Contributor

@jkva jkva commented Dec 6, 2021 •
edited
Loading

This PR affords the following:

  • TestNavigator testplan task links no longer direct to #;
  • each task has its own relative location, e.g. /run/7/task/5 which can be directly navigated to;
  • when no task-specific location is used, the first task is assumed as previously;
  • each task navigator link includes its status ('In Progress', 'Not Started', etc) as part of its accessible name; and
  • each task navigator link displays its status using a tooltip when either going into hover or focus state.

This resolves #374.

A screenshot of a partial browser window showing the task navigator. An arrow overlay shows the /run/7/task/11 number eleven associate with the current active task being eleven as well. A keyboard-focused task link shows a "Not Started" tooltop (white text on black background) at its top-right corner.

@jkva jkva requested a review from jscholes December 8, 2021 11:34
jkva
jkva commented Dec 8, 2021
View reviewed changes
client/components/TestRun/index.jsx
@@ -814,6 +835,7 @@ const TestRun = () => {
<TestNavigator
show={showTestNavigator}
tests={tests}
testPlanRunId={parseInt(testPlanRunId)}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of this explicit int typecasting; why is this not addressed by the routing regular expression?

@jkva jkva marked this pull request as ready for review December 8, 2021 11:42
@jkva jkva changed the title Use routable locations when navigating through testplan tasks. Use Routable Locations when Navigating Through Test Plan Tasks Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscholes jscholes jscholes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inaccessible Test Navigator Item Status Information Availability
2 participants
@jkva @jscholes