Editorial: Add notice on the _or condition depth. #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@domenic Can I ask you to review? |
|
It probably would be good to have a (normative) requirement for the minimum nesting level that browser should support? (with corresponding WPT tests) |
If my put myself in the web developers shoes, it is understandable. They should want to know the depth that works on all browsers. We currently have https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/web_tests/external/wpt/service-workers/service-worker/tentative/static-router/resources/router-rules.js;l=76;drc=bc4f2163da44000fc411e6aeff490f19c414b495 for the nested conditions. I do not come up with the case more nests are needed. Let me add such tests to not, and revisit here. |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 8, 2024
The specification does not define the maximum depth/width. However, the current WPT limit them. Let me move such WPTs to Chromium specific locations. In the coming CL, I will also write the WPT to ask the minimum depth/width as a response to: w3c/ServiceWorker#1714 Change-Id: I722667fbdc69aed32d8fa66d3e17050bf33c480a
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 8, 2024
The specification does not define the maximum depth/width. However, the current WPT limit them. Let me move such WPTs to Chromium specific locations. In the coming CL, I will also write the WPT to ask the minimum depth/width as a response to: w3c/ServiceWorker#1714 Change-Id: I722667fbdc69aed32d8fa66d3e17050bf33c480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999015 Reviewed-by: Keita Suzuki <[email protected]> Reviewed-by: Shunya Shishido <[email protected]> Commit-Queue: Yoshisato Yanagisawa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1380071}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 8, 2024
The specification does not define the maximum depth/width. However, the current WPT limit them. Let me move such WPTs to Chromium specific locations. In the coming CL, I will also write the WPT to ask the minimum depth/width as a response to: w3c/ServiceWorker#1714 Change-Id: I722667fbdc69aed32d8fa66d3e17050bf33c480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999015 Reviewed-by: Keita Suzuki <[email protected]> Reviewed-by: Shunya Shishido <[email protected]> Commit-Queue: Yoshisato Yanagisawa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1380071}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 10, 2024
…T., a=testonly Automatic update from web-platform-tests Move Chromium implementation specific WPT. The specification does not define the maximum depth/width. However, the current WPT limit them. Let me move such WPTs to Chromium specific locations. In the coming CL, I will also write the WPT to ask the minimum depth/width as a response to: w3c/ServiceWorker#1714 Change-Id: I722667fbdc69aed32d8fa66d3e17050bf33c480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999015 Reviewed-by: Keita Suzuki <[email protected]> Reviewed-by: Shunya Shishido <[email protected]> Commit-Queue: Yoshisato Yanagisawa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1380071} -- wpt-commits: af915520cc0da850f5031cdfb5172657ab7091a4 wpt-pr: 49047
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 12, 2024
…T., a=testonly Automatic update from web-platform-tests Move Chromium implementation specific WPT. The specification does not define the maximum depth/width. However, the current WPT limit them. Let me move such WPTs to Chromium specific locations. In the coming CL, I will also write the WPT to ask the minimum depth/width as a response to: w3c/ServiceWorker#1714 Change-Id: I722667fbdc69aed32d8fa66d3e17050bf33c480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999015 Reviewed-by: Keita Suzuki <[email protected]> Reviewed-by: Shunya Shishido <[email protected]> Commit-Queue: Yoshisato Yanagisawa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1380071} -- wpt-commits: af915520cc0da850f5031cdfb5172657ab7091a4 wpt-pr: 49047
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 16, 2024
…T., a=testonly Automatic update from web-platform-tests Move Chromium implementation specific WPT. The specification does not define the maximum depth/width. However, the current WPT limit them. Let me move such WPTs to Chromium specific locations. In the coming CL, I will also write the WPT to ask the minimum depth/width as a response to: w3c/ServiceWorker#1714 Change-Id: I722667fbdc69aed32d8fa66d3e17050bf33c480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999015 Reviewed-by: Keita Suzuki <suzukikeitachromium.org> Reviewed-by: Shunya Shishido <sisidovskichromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawachromium.org> Cr-Commit-Position: refs/heads/main{#1380071} -- wpt-commits: af915520cc0da850f5031cdfb5172657ab7091a4 wpt-pr: 49047 UltraBlame original commit: aa8a7fd4f293aa1f757f821c7fb13fd0cb381b4a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 16, 2024
…T., a=testonly Automatic update from web-platform-tests Move Chromium implementation specific WPT. The specification does not define the maximum depth/width. However, the current WPT limit them. Let me move such WPTs to Chromium specific locations. In the coming CL, I will also write the WPT to ask the minimum depth/width as a response to: w3c/ServiceWorker#1714 Change-Id: I722667fbdc69aed32d8fa66d3e17050bf33c480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999015 Reviewed-by: Keita Suzuki <suzukikeitachromium.org> Reviewed-by: Shunya Shishido <sisidovskichromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawachromium.org> Cr-Commit-Position: refs/heads/main{#1380071} -- wpt-commits: af915520cc0da850f5031cdfb5172657ab7091a4 wpt-pr: 49047 UltraBlame original commit: aa8a7fd4f293aa1f757f821c7fb13fd0cb381b4a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 16, 2024
…T., a=testonly Automatic update from web-platform-tests Move Chromium implementation specific WPT. The specification does not define the maximum depth/width. However, the current WPT limit them. Let me move such WPTs to Chromium specific locations. In the coming CL, I will also write the WPT to ask the minimum depth/width as a response to: w3c/ServiceWorker#1714 Change-Id: I722667fbdc69aed32d8fa66d3e17050bf33c480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999015 Reviewed-by: Keita Suzuki <suzukikeitachromium.org> Reviewed-by: Shunya Shishido <sisidovskichromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawachromium.org> Cr-Commit-Position: refs/heads/main{#1380071} -- wpt-commits: af915520cc0da850f5031cdfb5172657ab7091a4 wpt-pr: 49047 UltraBlame original commit: aa8a7fd4f293aa1f757f821c7fb13fd0cb381b4a
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Nov 16, 2024
…T., a=testonly Automatic update from web-platform-tests Move Chromium implementation specific WPT. The specification does not define the maximum depth/width. However, the current WPT limit them. Let me move such WPTs to Chromium specific locations. In the coming CL, I will also write the WPT to ask the minimum depth/width as a response to: w3c/ServiceWorker#1714 Change-Id: I722667fbdc69aed32d8fa66d3e17050bf33c480a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999015 Reviewed-by: Keita Suzuki <[email protected]> Reviewed-by: Shunya Shishido <[email protected]> Commit-Queue: Yoshisato Yanagisawa <[email protected]> Cr-Commit-Position: refs/heads/main@{#1380071} -- wpt-commits: af915520cc0da850f5031cdfb5172657ab7091a4 wpt-pr: 49047
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WICG/service-worker-static-routing-api#5 and WICG/service-worker-static-routing-api#6, it was suggested to limit the number of conditions in the or condition syntax, and depth of nested and/or conditions.
This PR adds notice on such limitations.
Preview | Diff