Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to module #26

Merged
merged 22 commits into from
Jul 11, 2022
Merged

Convert to module #26

merged 22 commits into from
Jul 11, 2022

Conversation

@JSAssassin JSAssassin requested review from aljones15 and davidlehn May 31, 2022 12:29
@JSAssassin JSAssassin marked this pull request as ready for review June 7, 2022 16:46
Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JSAssassin JSAssassin force-pushed the convert-to-module branch 2 times, most recently from 8a119e9 to e9a0787 Compare June 15, 2022 21:44
@JSAssassin JSAssassin force-pushed the convert-to-module branch from fca4881 to bf773f5 Compare July 5, 2022 12:00
@JSAssassin JSAssassin requested a review from aljones15 July 11, 2022 13:31
Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as this has been tested.

@JSAssassin JSAssassin merged commit a71a6a4 into main Jul 11, 2022
@JSAssassin JSAssassin deleted the convert-to-module branch July 11, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants