Add state & variables to GetExhangeResponse.
#428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigBlueHat
requested review from
msporny,
mavarley and
mkhraisha
as code owners
dlongley
requested changes
Oct 29, 2024
Co-authored-by: Dave Longley <[email protected]>
|
@dlongley let me know if you want more cleanup throughout. I'd prefer we merge this (if it's ready), though, and make an issue (or another PR) for further cleanup. |
dlongley
approved these changes
Oct 30, 2024
msporny
approved these changes
Nov 19, 2024
msporny
reviewed
Nov 19, 2024
|
Even though already merged, it seems worth correcting the spelling of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't track
stateif it's not there. 😃