-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove fixtures from the vc-api #411
Remove fixtures from the vc-api #411
Conversation
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
Signed-off-by: Patrick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should go in the BSL test suite, not the VC API specification. Test fixtures should live with the test suite.
The only exception to that rule are examples that are used in the specification, and ideally, those are dynamically generated using respec-vc.
@msporny noted, I will migrate these. Do we want to leave 1 valid |
I don't think we need an example right now, and if we do in the future, we can add it back in. Please remove the entire directory; thank you! |
@PatStLouis just message me when this PR is ready for review again and I'll review it then. thanks for the work and sorry I didn't know about the issue with this dir. |
Signed-off-by: Patrick <[email protected]>
@msporny @TallTed @aljones15 as per the discussions, I removed the fixtures directory entirely as it's undocumented and unused in the specification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks and sorry about the misunderstanding.
Looking for feedback around missing test cases.
Once we agree on which signature suite to use (my current preference will be
Ed25519Signature2020
), I will go ahead and sign these fixtures with a did key.