Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixtures from the vc-api #411

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

PatStLouis
Copy link
Collaborator

Looking for feedback around missing test cases.

Once we agree on which signature suite to use (my current preference will be Ed25519Signature2020), I will go ahead and sign these fixtures with a did key.

Signed-off-by: Patrick <[email protected]>
Copy link
Contributor

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should go in the BSL test suite, not the VC API specification. Test fixtures should live with the test suite.

The only exception to that rule are examples that are used in the specification, and ideally, those are dynamically generated using respec-vc.

fixtures/README.md Outdated Show resolved Hide resolved
@PatStLouis
Copy link
Collaborator Author

PatStLouis commented Aug 7, 2024

@msporny noted, I will migrate these. Do we want to leave 1 valid BitstringStatusList credential to use as a uri with examples in the vc-api specification? Otherwise I can remove the directory entirely including the revocationStatusList credential present

@msporny
Copy link
Contributor

msporny commented Aug 7, 2024

@msporny noted, I will migrate these. Do we want to leave 1 valid BitstringStatusList credential to use as a uri with examples in the vc-api specification? Otherwise I can remove the directory entirely including the revocationStatusList credential present

I don't think we need an example right now, and if we do in the future, we can add it back in. Please remove the entire directory; thank you!

@aljones15
Copy link
Contributor

@PatStLouis just message me when this PR is ready for review again and I'll review it then. thanks for the work and sorry I didn't know about the issue with this dir.

Signed-off-by: Patrick <[email protected]>
@PatStLouis PatStLouis changed the title Add BitstringStatusList status credential and credential entries unsigned fixtures Remove fixtures from the vc-api Aug 9, 2024
@PatStLouis PatStLouis requested review from msporny and TallTed August 9, 2024 17:08
@PatStLouis
Copy link
Collaborator Author

@msporny @TallTed @aljones15 as per the discussions, I removed the fixtures directory entirely as it's undocumented and unused in the specification.

Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks and sorry about the misunderstanding.

@msporny msporny merged commit fc94698 into w3c-ccg:main Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants