Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section for handling unknown options/data. #394

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Add section for handling unknown options/data. #394

merged 1 commit into from
Jun 25, 2024

Conversation

wes-smith
Copy link
Collaborator

@wes-smith wes-smith commented Jun 25, 2024 •
edited by pr-preview bot
Loading

  • adds text requiring implementations throw an error on receiving data, options, or option values not understood by the endpoint.

Preview | Diff

@wes-smith
Add section for handling unknown options/data.
1023ee6 
- adds text requiring implementations throw an error on receiving data, options, or option values not understood by the endpoint.
@wes-smith wes-smith linked an issue Jun 25, 2024 that may be closed by this pull request
Require implementations to throw errors if options (post bodies generally) are not understood #386
Closed
msporny
msporny approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, raised issue #395 to address this issue.

@msporny msporny merged commit a230e09 into main Jun 25, 2024
1 check passed
@msporny msporny deleted the 386-require-implementations-to-throw-errors-if-options-post-bodies-generally-are-not-understood branch June 25, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@msporny msporny msporny approved these changes

@mavarley mavarley Awaiting requested review from mavarley mavarley is a code owner

@mkhraisha mkhraisha Awaiting requested review from mkhraisha mkhraisha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Require implementations to throw errors if options (post bodies generally) are not understood
3 participants
@wes-smith @msporny @dlongley