Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update domain test #64

Merged
merged 4 commits into from
Jul 21, 2024
Merged

Update domain test #64

merged 4 commits into from
Jul 21, 2024

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Jul 16, 2024

Addresses: #75

@aljones15 aljones15 self-assigned this Jul 16, 2024
@aljones15 aljones15 requested review from BigBlueHat and tminard July 16, 2024 14:12
@aljones15 aljones15 marked this pull request as ready for review July 16, 2024 14:12
@aljones15 aljones15 requested a review from PatStLouis July 17, 2024 19:13
Copy link
Collaborator

@PatStLouis PatStLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, afaik this is only applicable to vpVerifiers am I correct?

@aljones15
Copy link
Contributor Author

Looks good to me, afaik this is only applicable to vpVerifiers am I correct?

sadly no, we don't even have a vpVerifiers stuff for this suite. maybe based on yesterday's conversation this Pr should be refactored? even more troubling is that issuer tests for domain and challenge as we have not tested against endpoints that ca create Verifiable Presentations at all.

@aljones15
Copy link
Contributor Author

merging this with an issue to vpVerifiers and other endpoints in the future: #82

@aljones15 aljones15 merged commit 1cd6ee3 into main Jul 21, 2024
2 checks passed
@aljones15 aljones15 deleted the update-domain-test branch July 21, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants