feat: add flag to install_vyper() for skipping validation
#33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
approved these changes
Jan 8, 2025
antazoey
force-pushed
the
feat/skip-validate
branch
from
2ac6a1d to
6b55552
Compare
charles-cooper
approved these changes
Jan 27, 2025
|
thanks! |
|
I am not sure why that windows test was failing still tho |
|
it's an existing issue on windows, not a regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Related issue: #32
How I did it
Add a bool kwarg and honor it.
How to verify it
This is on an arm64 device (mac):
obviously it still does not work but at least I have it, which helps me
Checklist